From 700ba1bcb39e082049c96fafdfaccfe5d83cd77e Mon Sep 17 00:00:00 2001 From: Lars Knoll Date: Wed, 18 Sep 2013 15:34:13 +0200 Subject: Use a StringRef for Managed::get() also store "toString" and "valueOf" as identifiers in the engine and fix two places where we compared strings the wrong way. Change-Id: I70612221e72d43ed0e3c496e4209681bf254cded Reviewed-by: Simon Hausmann --- src/qml/qml/qqmllistwrapper.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/qml/qml/qqmllistwrapper.cpp') diff --git a/src/qml/qml/qqmllistwrapper.cpp b/src/qml/qml/qqmllistwrapper.cpp index 23aca851a6..517c6c46db 100644 --- a/src/qml/qml/qqmllistwrapper.cpp +++ b/src/qml/qml/qqmllistwrapper.cpp @@ -98,14 +98,14 @@ QVariant QmlListWrapper::toVariant() const } -ReturnedValue QmlListWrapper::get(Managed *m, String *name, bool *hasProperty) +ReturnedValue QmlListWrapper::get(Managed *m, const StringRef name, bool *hasProperty) { QV4::ExecutionEngine *v4 = m->engine(); QmlListWrapper *w = m->as(); if (!w) v4->current->throwTypeError(); - if (name == v4->id_length && !w->object.isNull()) { + if (name->isEqualTo(v4->id_length) && !w->object.isNull()) { quint32 count = w->property.count ? w->property.count(&w->property) : 0; return Value::fromUInt32(count).asReturnedValue(); } -- cgit v1.2.3