From 2ab6a34a7e9c307a43c23262aeee398dc5fb91bc Mon Sep 17 00:00:00 2001 From: Simon Hausmann Date: Tue, 8 Apr 2014 11:19:04 +0200 Subject: Fix memory corruption in XHR implementation Now that the member data of Object is also on the GC heap, it is even more important to call the base implementation of markObjects when re-implementing it ;-) Fixes also three XHR auto tests (text, cdata and stateChangeCallingContext) Change-Id: Ifd033cac64a8cf27a9186d8cd9eb94369d8a60a5 Reviewed-by: Michael Brasser Reviewed-by: Friedemann Kleint --- src/qml/qml/qqmlxmlhttprequest.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'src/qml/qml/qqmlxmlhttprequest.cpp') diff --git a/src/qml/qml/qqmlxmlhttprequest.cpp b/src/qml/qml/qqmlxmlhttprequest.cpp index e2cdac16c0..fd27903b74 100644 --- a/src/qml/qml/qqmlxmlhttprequest.cpp +++ b/src/qml/qml/qqmlxmlhttprequest.cpp @@ -1650,6 +1650,7 @@ struct QQmlXMLHttpRequestCtor : public FunctionObject QQmlXMLHttpRequestCtor *c = that->as(); if (c->proto) c->proto->mark(e); + FunctionObject::markObjects(that, e); } static ReturnedValue construct(Managed *that, QV4::CallData *) { -- cgit v1.2.3