From aef0aac581fbbead07be939873e34045137b94ff Mon Sep 17 00:00:00 2001
From: Lars Knoll <lars.knoll@qt.io>
Date: Tue, 7 Jul 2020 12:24:25 +0200
Subject: Compile against latest qtbase

Adjust to the lastest changes in QList and QString.

Change-Id: I216b2746a3305222a21c5aead3aec6106ac1f035
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
---
 src/qml/jsruntime/qv4arraybuffer.cpp |  6 +++---
 src/qml/jsruntime/qv4urlobject.cpp   |  2 +-
 src/qml/qml/ftw/qstringhash_p.h      | 17 +++++++++++------
 src/qml/qml/qqmlxmlhttprequest.cpp   |  2 +-
 4 files changed, 16 insertions(+), 11 deletions(-)

(limited to 'src/qml')

diff --git a/src/qml/jsruntime/qv4arraybuffer.cpp b/src/qml/jsruntime/qv4arraybuffer.cpp
index a2fac21b29..3b361bcaf5 100644
--- a/src/qml/jsruntime/qv4arraybuffer.cpp
+++ b/src/qml/jsruntime/qv4arraybuffer.cpp
@@ -135,7 +135,7 @@ void Heap::SharedArrayBuffer::init(size_t length)
         internalClass->engine->throwRangeError(QStringLiteral("ArrayBuffer: out of memory"));
         return;
     }
-    auto data = new (&d) QArrayDataPointer<char>{ pair.first, pair.second, uint(length) };
+    auto data = new (&d) QArrayDataPointer<char>{ pair.first, pair.second, qsizetype(length) };
 
     // can't use appendInitialize() because we want to set the terminating '\0'
     memset(data->data(), 0, length + 1);
@@ -187,7 +187,7 @@ ReturnedValue SharedArrayBufferPrototype::method_get_byteLength(const FunctionOb
     if (!a || a->isDetachedBuffer() || !a->isSharedArrayBuffer())
         return b->engine()->throwTypeError();
 
-    return Encode(a->d()->data()->size);
+    return Encode(int(a->d()->data()->size));
 }
 
 ReturnedValue SharedArrayBufferPrototype::method_slice(const FunctionObject *b, const Value *thisObject, const Value *argv, int argc)
@@ -252,7 +252,7 @@ ReturnedValue ArrayBufferPrototype::method_get_byteLength(const FunctionObject *
     if (!a || a->isDetachedBuffer() || a->isSharedArrayBuffer())
         return f->engine()->throwTypeError();
 
-    return Encode(a->d()->data()->size);
+    return Encode(int(a->d()->data()->size));
 }
 
 ReturnedValue ArrayBufferPrototype::method_slice(const FunctionObject *b, const Value *thisObject, const Value *argv, int argc)
diff --git a/src/qml/jsruntime/qv4urlobject.cpp b/src/qml/jsruntime/qv4urlobject.cpp
index 6f9a9ecb69..937cd6e3a2 100644
--- a/src/qml/jsruntime/qv4urlobject.cpp
+++ b/src/qml/jsruntime/qv4urlobject.cpp
@@ -1270,7 +1270,7 @@ ReturnedValue UrlSearchParamsPrototype::method_set(const FunctionObject *b, cons
 
     bool matched = false;
 
-    for (auto *it = params.begin(); it != params.end();) {
+    for (auto it = params.begin(); it != params.end();) {
         QStringList &param = *it;
         if (param[0] == name) {
             if (!matched) {
diff --git a/src/qml/qml/ftw/qstringhash_p.h b/src/qml/qml/ftw/qstringhash_p.h
index 7a2184d63f..c4411b4814 100644
--- a/src/qml/qml/ftw/qstringhash_p.h
+++ b/src/qml/qml/ftw/qstringhash_p.h
@@ -78,7 +78,8 @@ public:
     , arrayData(mutableStringData(key).d_ptr())
     , strData(mutableStringData(key).data())
     {
-        arrayData->ref();
+        if (arrayData)
+            arrayData->ref();
         setQString(true);
     }
 
@@ -93,7 +94,8 @@ public:
         setQString(o.isQString());
         if (isQString()) {
             strData = o.strData;
-            arrayData->ref();
+            if (arrayData)
+                arrayData->ref();
         } else {
             ckey = o.ckey;
         }
@@ -101,7 +103,7 @@ public:
 
     ~QStringHashNode()
     {
-        if (isQString() && !arrayData->deref())
+        if (isQString() && arrayData && !arrayData->deref())
             QTypedArrayData<char16_t>::deallocate(arrayData);
     }
 
@@ -125,7 +127,8 @@ public:
     inline QHashedString key() const
     {
         if (isQString()) {
-            arrayData->ref();
+            if (arrayData)
+                arrayData->ref();
             return QHashedString(QString(QStringPrivate(arrayData, strData, length)), hash);
         }
 
@@ -528,7 +531,8 @@ void QStringHash<T>::initializeNode(Node *node, const QHashedString &key)
     node->hash = key.hash();
     node->arrayData = mutableStringData(key).d_ptr();
     node->strData = mutableStringData(key).data();
-    node->arrayData->ref();
+    if (node->arrayData)
+        node->arrayData->ref();
     node->setQString(true);
 }
 
@@ -568,7 +572,8 @@ typename QStringHash<T>::Node *QStringHash<T>::takeNode(const Node &o)
         if (o.isQString()) {
             rv->strData = o.strData;
             rv->setQString(true);
-            rv->arrayData->ref();
+            if (rv->arrayData)
+                rv->arrayData->ref();
         } else {
             rv->ckey = o.ckey;
         }
diff --git a/src/qml/qml/qqmlxmlhttprequest.cpp b/src/qml/qml/qqmlxmlhttprequest.cpp
index 9b06bd77ca..aeb57a7768 100644
--- a/src/qml/qml/qqmlxmlhttprequest.cpp
+++ b/src/qml/qml/qqmlxmlhttprequest.cpp
@@ -702,7 +702,7 @@ ReturnedValue CharacterData::method_length(const FunctionObject *b, const Value
     if (!r)
         RETURN_UNDEFINED();
 
-    return Encode(r->d()->d->data.length());
+    return Encode(int(r->d()->d->data.length()));
 }
 
 ReturnedValue CharacterData::prototype(ExecutionEngine *v4)
-- 
cgit v1.2.3