From 1f6b8123c3cbbbbd956def9347c1453f771bb8e9 Mon Sep 17 00:00:00 2001 From: Fabian Kosmale Date: Wed, 17 Feb 2021 08:17:50 +0100 Subject: CodeChecker: Assert that pointer canot be null In the AST, the type always has a name. Change-Id: Ifc299573132b9edeb4c0b96054a101d95332236a Reviewed-by: Ulf Hermann (cherry picked from commit c6c37d12633cc9fc3be1a1aa8e18d1013f3ab2d9) --- src/qmlcompiler/qqmljsimportvisitor.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/qmlcompiler/qqmljsimportvisitor.cpp') diff --git a/src/qmlcompiler/qqmljsimportvisitor.cpp b/src/qmlcompiler/qqmljsimportvisitor.cpp index 8b57ac9b54..11ab47e455 100644 --- a/src/qmlcompiler/qqmljsimportvisitor.cpp +++ b/src/qmlcompiler/qqmljsimportvisitor.cpp @@ -473,6 +473,8 @@ bool QQmlJSImportVisitor::visit(QQmlJS::AST::FormalParameterList *fpl) bool QQmlJSImportVisitor::visit(QQmlJS::AST::UiObjectBinding *uiob) { // property QtObject __styleData: QtObject {...} + + Q_ASSERT(uiob->qualifiedTypeNameId); QString name; for (auto id = uiob->qualifiedTypeNameId; id; id = id->next) name += id->name.toString() + QLatin1Char('.'); @@ -491,8 +493,7 @@ bool QQmlJSImportVisitor::visit(QQmlJS::AST::UiObjectBinding *uiob) } enterEnvironment(QQmlJSScope::QMLScope, name, - uiob->qualifiedTypeNameId ? uiob->qualifiedTypeNameId->identifierToken - : uiob->firstSourceLocation()); + uiob->qualifiedTypeNameId->identifierToken); m_currentScope->resolveTypes(m_rootScopeImports); return true; } -- cgit v1.2.3