From 8784a2778063cf928b27a908f6580ed37cb4035d Mon Sep 17 00:00:00 2001 From: Ulf Hermann Date: Fri, 12 Feb 2021 08:53:00 +0100 Subject: Use functions as signal handlers when accessing parameters Injected signal handlers are bad practice because they aren't declared. Task-number: QTBUG-89943 Change-Id: I3a691f68342a199bd63034637aa7ed438e3a037b Reviewed-by: Fabian Kosmale (cherry picked from commit 4cc91a6a0e4f9063233a4d6554ae64855cf99c14) Reviewed-by: Qt Cherry-pick Bot --- src/quick/items/qquickitem.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/quick/items/qquickitem.cpp') diff --git a/src/quick/items/qquickitem.cpp b/src/quick/items/qquickitem.cpp index 38e83e08ff..d9733309b1 100644 --- a/src/quick/items/qquickitem.cpp +++ b/src/quick/items/qquickitem.cpp @@ -968,7 +968,7 @@ bool QQuickKeysAttached::isConnected(const char *signalName) const focus: true // Ensure that we get escape key press events first. - Keys.onShortcutOverride: event.accepted = (event.key === Qt.Key_Escape) + Keys.onShortcutOverride: (event)=> event.accepted = (event.key === Qt.Key_Escape) Keys.onEscapePressed: { console.log("escapeItem is handling escape"); @@ -1922,7 +1922,7 @@ void QQuickItemPrivate::updateSubFocusItem(QQuickItem *scope, bool focus) Item { focus: true - Keys.onPressed: { + Keys.onPressed: (event)=> { if (event.key == Qt.Key_Left) { console.log("move left"); event.accepted = true; -- cgit v1.2.3