From 43c93a55e28a4655d8bc8d49a81b7802d7157244 Mon Sep 17 00:00:00 2001 From: Frederik Gladhorn Date: Wed, 3 Dec 2014 14:42:12 +0100 Subject: Error out when trying to set an item as its own parent Task-number: QTBUG-43063 Change-Id: I92a33047ac7fa2afeff4986b6e42c07afbc59918 Reviewed-by: J-P Nurmi --- src/quick/items/qquickitem.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/quick/items/qquickitem.cpp') diff --git a/src/quick/items/qquickitem.cpp b/src/quick/items/qquickitem.cpp index 825dd8ddfa..2722f48ce9 100644 --- a/src/quick/items/qquickitem.cpp +++ b/src/quick/items/qquickitem.cpp @@ -2481,7 +2481,7 @@ void QQuickItem::setParentItem(QQuickItem *parentItem) return; if (parentItem) { - QQuickItem *itemAncestor = parentItem->parentItem(); + QQuickItem *itemAncestor = parentItem; while (itemAncestor != 0) { if (itemAncestor == this) { qWarning("QQuickItem::setParentItem: Parent is already part of this items subtree."); -- cgit v1.2.3