From 79aa1df7b424240ab522c5fb3a7831c71497b7e1 Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Mon, 6 Jul 2015 14:51:45 +0200 Subject: Fix QQuickListViewPrivate::releaseItem() Fixes a regression introduced by 1e3924d. The FxViewItem gets deleted by QQuickItemViewPrivate::releaseItem(), so the QQuickItem pointer must be stored before calling the base class implementation. Change-Id: I0bcffc7bee8a4cdbebdce0fe2d2b990bfa52dc6c Reviewed-by: Simon Hausmann --- src/quick/items/qquicklistview.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/quick/items/qquicklistview.cpp') diff --git a/src/quick/items/qquicklistview.cpp b/src/quick/items/qquicklistview.cpp index a2920f8bad..e37aca01c5 100644 --- a/src/quick/items/qquicklistview.cpp +++ b/src/quick/items/qquicklistview.cpp @@ -609,10 +609,11 @@ bool QQuickListViewPrivate::releaseItem(FxViewItem *item) if (!item || !model) return true; + QPointer it = item->item; QQuickListViewAttached *att = static_cast(item->attached); bool released = QQuickItemViewPrivate::releaseItem(item); - if (released && item->item && att && att->m_sectionItem) { + if (released && it && att && att->m_sectionItem) { // We hold no more references to this item int i = 0; do { -- cgit v1.2.3