From a135f3d6c3202b37eda0f1e94292f795f9e575ca Mon Sep 17 00:00:00 2001 From: Wang Chuan Date: Mon, 4 May 2020 11:09:13 +0800 Subject: QQuickLoader: prevent clearing initial properties after active = true After commit b6d88c73, we implement the method [disposeInitialPropertyValues] and clear the cache of initial properties actually. Since we also call this method after source loaded, it will cause loss of initial properties after active = true. Fixes: QTBUG-83895 Change-Id: Iaa500fff14dcaad79a9e68dcbac9f65fa8720456 Reviewed-by: Shawn Rutledge Reviewed-by: Fabian Kosmale Reviewed-by: Simon Hausmann --- src/quick/items/qquickloader.cpp | 1 - 1 file changed, 1 deletion(-) (limited to 'src/quick/items/qquickloader.cpp') diff --git a/src/quick/items/qquickloader.cpp b/src/quick/items/qquickloader.cpp index 43b70b23c2..40e0c3219a 100644 --- a/src/quick/items/qquickloader.cpp +++ b/src/quick/items/qquickloader.cpp @@ -711,7 +711,6 @@ void QQuickLoaderPrivate::incubatorStateChanged(QQmlIncubator::Status status) emit q->progressChanged(); if (status == QQmlIncubator::Ready) emit q->loaded(); - disposeInitialPropertyValues(); // cleanup } void QQuickLoaderPrivate::_q_sourceLoaded() -- cgit v1.2.3