From 3ca659657ccaf0d850e661c9312e0f98e153c9ff Mon Sep 17 00:00:00 2001
From: Simon Hausmann <simon.hausmann@qt.io>
Date: Fri, 10 Jan 2020 12:50:20 +0100
Subject: Fix crash in tst_qquicktableview

Avoid a range-for over a list that's sometimes modified during the
iteration.

Change-Id: I4888ace4ebb86bfaa9f92d7e6272114c0af01421
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
---
 src/quick/items/qquicktableview.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'src/quick/items/qquicktableview.cpp')

diff --git a/src/quick/items/qquicktableview.cpp b/src/quick/items/qquicktableview.cpp
index 4018ce33a5..8c0512065a 100644
--- a/src/quick/items/qquicktableview.cpp
+++ b/src/quick/items/qquicktableview.cpp
@@ -2054,7 +2054,8 @@ bool QQuickTableViewPrivate::updateTableRecursive()
     if (!updateComplete)
         return false;
 
-    for (auto syncChild : qAsConst(syncChildren)) {
+    const auto children = syncChildren;
+    for (auto syncChild : children) {
         auto syncChild_d = syncChild->d_func();
         syncChild_d->scheduledRebuildOptions |= rebuildOptions;
 
-- 
cgit v1.2.3