From 21fd17d7c1fca77e802ba2d3fd5aeebcdef157e4 Mon Sep 17 00:00:00 2001 From: Jesus Fernandez Date: Sun, 25 Jun 2017 10:37:49 +0200 Subject: Add Q_ASSERT to test prevNode To make Coverity happy: *** CID 181275: Null pointer dereferences (FORWARD_NULL) /qtdeclarative/src/imports/shapes/qquickshapegenericrenderer.cpp: 503 in QQuickShapeGenericRenderer::updateNode()() 497 QQuickShapeGenericNode **nodePtr = &m_rootNode; 498 QQuickShapeGenericNode *prevNode = nullptr; 499 500 for (ShapePathData &d : m_sp) { 501 if (!*nodePtr) { 502 *nodePtr = new QQuickShapeGenericNode; >>> CID 181275: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "prevNode". 503 prevNode->m_next = *nodePtr; 504 prevNode->appendChildNode(*nodePtr); 505 } 506 507 QQuickShapeGenericNode *node = *nodePtr; 508 Change-Id: I76e79ef6fe94aa8b0e77f79724101b4682dab6d3 Coverity-Id: 181275 Reviewed-by: Laszlo Agocs --- src/imports/shapes/qquickshapegenericrenderer.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'src') diff --git a/src/imports/shapes/qquickshapegenericrenderer.cpp b/src/imports/shapes/qquickshapegenericrenderer.cpp index 47203698d5..4a4176793f 100644 --- a/src/imports/shapes/qquickshapegenericrenderer.cpp +++ b/src/imports/shapes/qquickshapegenericrenderer.cpp @@ -499,6 +499,7 @@ void QQuickShapeGenericRenderer::updateNode() for (ShapePathData &d : m_sp) { if (!*nodePtr) { + Q_ASSERT(prevNode); *nodePtr = new QQuickShapeGenericNode; prevNode->m_next = *nodePtr; prevNode->appendChildNode(*nodePtr); -- cgit v1.2.3