From e4912d9b30e4cd202cd4895766b879f0980c37f6 Mon Sep 17 00:00:00 2001 From: Erik Verbruggen Date: Fri, 7 Jul 2017 15:45:10 +0200 Subject: Fix assignments-to-self like x=x For those expressions, the load and store of x do need to be generated: they are observable and might have side-effects. Change-Id: Ifbfdfa1cb40c58ca99468548b94a42de9b704ae0 Reviewed-by: Simon Hausmann --- src/qml/compiler/qv4codegen.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'src') diff --git a/src/qml/compiler/qv4codegen.cpp b/src/qml/compiler/qv4codegen.cpp index ae929331a2..015c31f8d0 100644 --- a/src/qml/compiler/qv4codegen.cpp +++ b/src/qml/compiler/qv4codegen.cpp @@ -2570,9 +2570,6 @@ bool Codegen::Reference::operator==(const Codegen::Reference &other) const void Codegen::Reference::storeConsume(Reference &r) const { - if (*this == r) - return; - if (!isSimple() && !r.isSimple()) { r.asRValue(); // trigger load -- cgit v1.2.3