From ee06564a979a4677d117bc29e610e0368671fbdd Mon Sep 17 00:00:00 2001 From: Kent Hansen Date: Thu, 4 Aug 2011 13:42:15 +0200 Subject: Remove dead code from QJSValuePrivate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit reinitialize() was used to implement setGlobalObject() and setScriptClass() in the QtScript/V8 port, but those functions will not be part of the new JS API. Change-Id: I030d371659136a407636c7a13afe7623a60a2837 Reviewed-on: http://codereview.qt.nokia.com/2623 Reviewed-by: Qt Sanity Bot Reviewed-by: Jędrzej Nowacki --- src/declarative/qml/v8/qjsvalue_impl_p.h | 20 -------------------- src/declarative/qml/v8/qjsvalue_p.h | 1 - 2 files changed, 21 deletions(-) (limited to 'src') diff --git a/src/declarative/qml/v8/qjsvalue_impl_p.h b/src/declarative/qml/v8/qjsvalue_impl_p.h index 1970505f13..414109cea7 100644 --- a/src/declarative/qml/v8/qjsvalue_impl_p.h +++ b/src/declarative/qml/v8/qjsvalue_impl_p.h @@ -1051,26 +1051,6 @@ void QJSValuePrivate::reinitialize() m_state = Invalid; } -/*! - \internal - reinitialize this value to an JSValue. -*/ -void QJSValuePrivate::reinitialize(QV8Engine* engine, v8::Handle value) -{ - Q_ASSERT_X(this != InvalidValue(), Q_FUNC_INFO, "static invalid can't be reinitialized to a different value"); - if (isJSBased()) { - m_value.Dispose(); - // avoid double registration - m_engine->unregisterValue(this); - } else if (isStringBased()) { - delete u.m_string; - } - m_engine = engine; - m_state = JSValue; - m_value = v8::Persistent::New(value); - m_engine->registerValue(this); -} - QV8Engine* QJSValuePrivate::engine() const { return m_engine; diff --git a/src/declarative/qml/v8/qjsvalue_p.h b/src/declarative/qml/v8/qjsvalue_p.h index 8189f45d59..b50f573b5c 100644 --- a/src/declarative/qml/v8/qjsvalue_p.h +++ b/src/declarative/qml/v8/qjsvalue_p.h @@ -82,7 +82,6 @@ public: inline QJSValuePrivate(QV8Engine *engine, QJSValue::SpecialValue value); inline QJSValuePrivate(QV8Engine *engine, v8::Handle); inline void reinitialize(); - inline void reinitialize(QV8Engine *engine, v8::Handle value); inline bool toBool() const; inline double toNumber() const; -- cgit v1.2.3