From 350a74ec69b535df07ad7ca45415090749c75293 Mon Sep 17 00:00:00 2001 From: Erik Verbruggen Date: Tue, 8 Mar 2016 10:13:15 +0100 Subject: Particles: Shrink QQuickParticleData by 2 pointers. Samegame creates about 23,000 particles, so this reduces the memory by ~180kb on 32bit, so ~360kb on 64bit. Change-Id: I0581524ab232b474c5d43abeabd7ebf6174e740f Reviewed-by: Lars Knoll --- .../qquickcustomaffector/tst_qquickcustomaffector.cpp | 12 ++++++------ tests/auto/particles/qquickgravity/tst_qquickgravity.cpp | 2 +- .../qquickparticlesystem/tst_qquickparticlesystem.cpp | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) (limited to 'tests/auto/particles') diff --git a/tests/auto/particles/qquickcustomaffector/tst_qquickcustomaffector.cpp b/tests/auto/particles/qquickcustomaffector/tst_qquickcustomaffector.cpp index 50d28f8e77..fb15af4dd1 100644 --- a/tests/auto/particles/qquickcustomaffector/tst_qquickcustomaffector.cpp +++ b/tests/auto/particles/qquickcustomaffector/tst_qquickcustomaffector.cpp @@ -63,7 +63,7 @@ void tst_qquickcustomaffector::test_basic() if (d->t == -1) continue; //Particle data unused //in CI the whole simulation often happens at once, so dead particles end up missing out - if (!d->stillAlive()) + if (!d->stillAlive(system)) continue; //parameters no longer get set once you die QCOMPARE(d->x, 100.f); @@ -95,13 +95,13 @@ void tst_qquickcustomaffector::test_move() foreach (QQuickParticleData *d, system->groupData[0]->data) { if (d->t == -1) continue; //Particle data unused - if (!d->stillAlive()) + if (!d->stillAlive(system)) continue; //parameters no longer get set once you die - QVERIFY(myFuzzyCompare(d->curX(), 50.0)); - QVERIFY(myFuzzyCompare(d->curY(), 50.0)); - QVERIFY(myFuzzyCompare(d->curVX(), 50.0)); - QVERIFY(myFuzzyCompare(d->curVY(), 50.0)); + QVERIFY(myFuzzyCompare(d->curX(system), 50.0)); + QVERIFY(myFuzzyCompare(d->curY(system), 50.0)); + QVERIFY(myFuzzyCompare(d->curVX(system), 50.0)); + QVERIFY(myFuzzyCompare(d->curVY(system), 50.0)); QVERIFY(myFuzzyCompare(d->curAX(), 50.0)); QVERIFY(myFuzzyCompare(d->curAY(), 50.0)); QCOMPARE(d->lifeSpan, 0.5f); diff --git a/tests/auto/particles/qquickgravity/tst_qquickgravity.cpp b/tests/auto/particles/qquickgravity/tst_qquickgravity.cpp index 05e450dd92..8ef075dc9b 100644 --- a/tests/auto/particles/qquickgravity/tst_qquickgravity.cpp +++ b/tests/auto/particles/qquickgravity/tst_qquickgravity.cpp @@ -59,7 +59,7 @@ void tst_qquickgravity::test_basic() QVERIFY(extremelyFuzzyCompare(system->groupData[0]->size(), 500, 10)); float mag = 707.10678f; foreach (QQuickParticleData *d, system->groupData[0]->data) { - if (d->t == -1 || !d->stillAlive()) + if (d->t == -1 || !d->stillAlive(system)) continue; //Particle data unused or dead float t = ((qreal)system->timeInt/1000.0) - d->t; diff --git a/tests/auto/particles/qquickparticlesystem/tst_qquickparticlesystem.cpp b/tests/auto/particles/qquickparticlesystem/tst_qquickparticlesystem.cpp index 31b6f6f1c8..4a3c5cdc74 100644 --- a/tests/auto/particles/qquickparticlesystem/tst_qquickparticlesystem.cpp +++ b/tests/auto/particles/qquickparticlesystem/tst_qquickparticlesystem.cpp @@ -62,7 +62,7 @@ void tst_qquickparticlesystem::test_basic() if (d->t == -1) continue; //Particle data unused - if (d->stillAlive()) + if (d->stillAlive(system)) stillAlive++; QCOMPARE(d->x, 0.f); QCOMPARE(d->y, 0.f); -- cgit v1.2.3