From cd5ca0a582dda5e49d97e5db6b2b64b30e5553bd Mon Sep 17 00:00:00 2001 From: Kai Koehne Date: Thu, 12 Mar 2015 09:41:08 +0100 Subject: Remove bogus autotests for invalid ports Qt itself doesn't prevent opening a socket in the reserved port range. So what these tests actually check is the system configuration, not Qt. Task-number: QTBUG-44952 Change-Id: Iee6d6d1a5a7a0f4d2039300ccbbbe8bf55a519b9 Reviewed-by: Ulf Hermann Reviewed-by: Friedemann Kleint Reviewed-by: Simon Hausmann --- .../tst_qqmldebuggingenabler.cpp | 68 ---------------------- 1 file changed, 68 deletions(-) (limited to 'tests/auto/qml/debugger') diff --git a/tests/auto/qml/debugger/qqmldebuggingenabler/tst_qqmldebuggingenabler.cpp b/tests/auto/qml/debugger/qqmldebuggingenabler/tst_qqmldebuggingenabler.cpp index 7f8ded51ba..73abc03e28 100644 --- a/tests/auto/qml/debugger/qqmldebuggingenabler/tst_qqmldebuggingenabler.cpp +++ b/tests/auto/qml/debugger/qqmldebuggingenabler/tst_qqmldebuggingenabler.cpp @@ -55,17 +55,9 @@ private slots: void cleanup(); void qmlscene(); void qmlsceneBlock(); - void qmlsceneInvalidPorts(); - void qmlsceneBlockInvalidPorts(); - void qmlsceneMixedPorts(); - void qmlsceneBlockMixedPorts(); void custom(); void customBlock(); - void customInvalidPorts(); - void customBlockInvalidPorts(); - void customMixedPorts(); - void customBlockMixedPorts(); private: QQmlDebugProcess *process; @@ -161,30 +153,6 @@ void tst_QQmlDebuggingEnabler::qmlsceneBlock() QVERIFY(init(true, true, 5555, 5565)); } -void tst_QQmlDebuggingEnabler::qmlsceneInvalidPorts() -{ - QVERIFY(!init(false, true, 10, 20)); - QVERIFY(process->output().contains( - QLatin1String("QML Debugger: Unable to listen to ports 10 - 20."))); -} - -void tst_QQmlDebuggingEnabler::qmlsceneBlockInvalidPorts() -{ - QVERIFY(!init(true, true, 10, 20)); - QVERIFY(process->output().contains( - QLatin1String("QML Debugger: Unable to listen to ports 10 - 20."))); -} - -void tst_QQmlDebuggingEnabler::qmlsceneMixedPorts() -{ - QVERIFY(init(false, true, 1020, 1030)); -} - -void tst_QQmlDebuggingEnabler::qmlsceneBlockMixedPorts() -{ - QVERIFY(init(true, true, 1020, 1030)); -} - void tst_QQmlDebuggingEnabler::custom() { QVERIFY(init(false, false, 5555, 5565)); @@ -195,42 +163,6 @@ void tst_QQmlDebuggingEnabler::customBlock() QVERIFY(init(true, false, 5555, 5565)); } -void tst_QQmlDebuggingEnabler::customInvalidPorts() -{ - QVERIFY(!init(false, false, 10, 20)); - for (int i = 10; i < 20; ++i) { - QVERIFY(process->output().contains( - QString(QLatin1String("QML Debugger: Unable to listen to port %1.")).arg(i))); - } -} - -void tst_QQmlDebuggingEnabler::customBlockInvalidPorts() -{ - QVERIFY(!init(true, false, 10, 20)); - for (int i = 10; i < 20; ++i) { - QVERIFY(process->output().contains( - QString(QLatin1String("QML Debugger: Unable to listen to port %1.")).arg(i))); - } -} - -void tst_QQmlDebuggingEnabler::customMixedPorts() -{ - QVERIFY(init(false, false, 1020, 1030)); - for (int i = 1020; i < 1024; ++i) { - QVERIFY(process->output().contains( - QString(QLatin1String("QML Debugger: Unable to listen to port %1.")).arg(i))); - } -} - -void tst_QQmlDebuggingEnabler::customBlockMixedPorts() -{ - QVERIFY(init(true, false, 1020, 1030)); - for (int i = 1020; i < 1024; ++i) { - QVERIFY(process->output().contains( - QString(QLatin1String("QML Debugger: Unable to listen to port %1.")).arg(i))); - } -} - namespace QQmlDebuggingEnablerTest { QTEST_MAIN(tst_QQmlDebuggingEnabler) } -- cgit v1.2.3