From 20b376b64a11b4bda18aa1abda543586f04688e8 Mon Sep 17 00:00:00 2001
From: Mitch Curtis <mitch.curtis@qt.io>
Date: Mon, 23 Apr 2018 14:14:56 +0200
Subject: Print function identifier when calling toString() on a function

Task-number: QTBUG-50669
Change-Id: Ia0e9491b12ca1db1da2bfa8eb5ca8bbe4658f699
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
---
 tests/auto/qml/qjsengine/tst_qjsengine.cpp | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

(limited to 'tests/auto/qml/qjsengine/tst_qjsengine.cpp')

diff --git a/tests/auto/qml/qjsengine/tst_qjsengine.cpp b/tests/auto/qml/qjsengine/tst_qjsengine.cpp
index 85b4484403..911da1b20c 100644
--- a/tests/auto/qml/qjsengine/tst_qjsengine.cpp
+++ b/tests/auto/qml/qjsengine/tst_qjsengine.cpp
@@ -212,6 +212,9 @@ private slots:
 
     void deleteInsideForIn();
 
+    void functionToString_data();
+    void functionToString();
+
 signals:
     void testSignal();
 };
@@ -4220,6 +4223,30 @@ void tst_QJSEngine::deleteInsideForIn()
     QCOMPARE(iterationCount.toInt(), 4);
 }
 
+void tst_QJSEngine::functionToString_data()
+{
+    QTest::addColumn<QString>("source");
+    QTest::addColumn<QString>("expectedString");
+
+    QTest::newRow("named function") << QString::fromLatin1("function f() {}; f.toString()")
+        << QString::fromLatin1("function f() { [code] }");
+    QTest::newRow("anonymous function") << QString::fromLatin1("(function() {}).toString()")
+        << QString::fromLatin1("function() { [code] }");
+}
+
+// Tests that function.toString() prints the function's name.
+void tst_QJSEngine::functionToString()
+{
+    QFETCH(QString, source);
+    QFETCH(QString, expectedString);
+
+    QJSEngine engine;
+    engine.installExtensions(QJSEngine::AllExtensions);
+    QJSValue evaluationResult = engine.evaluate(source);
+    QVERIFY(!evaluationResult.isError());
+    QCOMPARE(evaluationResult.toString(), expectedString);
+}
+
 QTEST_MAIN(tst_QJSEngine)
 
 #include "tst_qjsengine.moc"
-- 
cgit v1.2.3