From 392521048ce6ef43a127b3dba199eee58557b1f6 Mon Sep 17 00:00:00 2001 From: Fabian Kosmale Date: Fri, 14 Jun 2019 14:21:25 +0200 Subject: Extend linter to check for unqualified ids The linter has gained a new option (-U/--check-unqualified). If run with this option, it warns about occurrences of unqualified identifiers. Furthermore, it attempts to detect the reason for why the identifier can be used unqalified: - If the id originates from the root element, it suggests to qualify the access either with the root element's id, or with "parent" if applicable. - If the id is the parameter of a signal, it suggests to use functions in the handler, instead of relying on the signal parameters to be "magically" injected into scope. The linter does not attempt to handle with statements, but warns the user instead that they are a bad idea. Change-Id: I9aaf28c37595d84886a1071d49b86799b222a617 Reviewed-by: Simon Hausmann --- tests/auto/qml/qmllint/data/WithStatement.qml | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 tests/auto/qml/qmllint/data/WithStatement.qml (limited to 'tests/auto/qml/qmllint/data/WithStatement.qml') diff --git a/tests/auto/qml/qmllint/data/WithStatement.qml b/tests/auto/qml/qmllint/data/WithStatement.qml new file mode 100644 index 0000000000..5641f21eeb --- /dev/null +++ b/tests/auto/qml/qmllint/data/WithStatement.qml @@ -0,0 +1,13 @@ +import QtQuick 2.0 + +Item { + Item { + id: target + property int test: 42 + } + Component.onCompleted: { + with(target) { + console.log(test); + } + } +} -- cgit v1.2.3