From 06e962f263a86c4b66e1c6195b3d2615695fea1e Mon Sep 17 00:00:00 2001 From: Shawn Rutledge Date: Wed, 21 Feb 2018 11:52:59 +0100 Subject: init variables where they are declared when possible (clang-tidy) clang-tidy -p compile_commands.json $file -checks='-*,modernize-use-default-member-init,readability-redundant-member-init' -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' -header-filter='qtdeclarative' -fix Change-Id: I705f3235ff129ba68b0d8dad54a083e29fcead5f Reviewed-by: Johan Helsing --- tests/auto/qml/qqmlnotifier/tst_qqmlnotifier.cpp | 36 ++++++++++-------------- 1 file changed, 15 insertions(+), 21 deletions(-) (limited to 'tests/auto/qml/qqmlnotifier') diff --git a/tests/auto/qml/qqmlnotifier/tst_qqmlnotifier.cpp b/tests/auto/qml/qqmlnotifier/tst_qqmlnotifier.cpp index 381ae98195..8811f779bb 100644 --- a/tests/auto/qml/qqmlnotifier/tst_qqmlnotifier.cpp +++ b/tests/auto/qml/qqmlnotifier/tst_qqmlnotifier.cpp @@ -46,21 +46,17 @@ class ExportedClass : public QObject Q_PROPERTY(int v4BindingProp2 READ v4BindingProp2 NOTIFY v4BindingProp2Changed) Q_PROPERTY(int scriptBindingProp READ scriptBindingProp NOTIFY scriptBindingPropChanged) public: - int qmlObjectPropConnections; - int cppObjectPropConnections; - int unboundPropConnections; - int v8BindingPropConnections; - int v4BindingPropConnections; - int v4BindingProp2Connections; - int scriptBindingPropConnections; - int boundSignalConnections; - int unusedSignalConnections; - - ExportedClass() - : qmlObjectPropConnections(0), cppObjectPropConnections(0), unboundPropConnections(0), - v8BindingPropConnections(0), v4BindingPropConnections(0), v4BindingProp2Connections(0), - scriptBindingPropConnections(0), boundSignalConnections(0), unusedSignalConnections(0) - {} + int qmlObjectPropConnections = 0; + int cppObjectPropConnections = 0; + int unboundPropConnections = 0; + int v8BindingPropConnections = 0; + int v4BindingPropConnections = 0; + int v4BindingProp2Connections = 0; + int scriptBindingPropConnections = 0; + int boundSignalConnections = 0; + int unusedSignalConnections = 0; + + ExportedClass() {} ~ExportedClass() { @@ -141,9 +137,7 @@ class tst_qqmlnotifier : public QQmlDataTest { Q_OBJECT public: - tst_qqmlnotifier() - : root(nullptr), exportedClass(nullptr), exportedObject(nullptr) - {} + tst_qqmlnotifier() {} private slots: void initTestCase() override; @@ -166,9 +160,9 @@ private: void createObjects(); QQmlEngine engine; - QObject *root; - ExportedClass *exportedClass; - ExportedClass *exportedObject; + QObject *root = nullptr; + ExportedClass *exportedClass = nullptr; + ExportedClass *exportedObject = nullptr; }; void tst_qqmlnotifier::initTestCase() -- cgit v1.2.3