From 4660f51f25a6c56182dff0ea24f7c1ad2bac9cea Mon Sep 17 00:00:00 2001 From: Maximilian Goldstein Date: Fri, 12 Feb 2021 11:32:53 +0100 Subject: qmllint: Fix false unknown grouped property warning We seem to be checking grouped properties twice by endVisit(UiObjectBinding*) and endVisit(UiObjectDefinition*). So the UiObjectBinding variant is removed here as this gets run before all type information is available. Change-Id: Idfe23869792f787df6109cde3b6bc1d96cce3dc3 Reviewed-by: Fabian Kosmale --- tests/auto/qml/qmllint/data/groupedScope.qml | 7 +++++++ tests/auto/qml/qmllint/tst_qmllint.cpp | 1 + 2 files changed, 8 insertions(+) create mode 100644 tests/auto/qml/qmllint/data/groupedScope.qml (limited to 'tests/auto/qml') diff --git a/tests/auto/qml/qmllint/data/groupedScope.qml b/tests/auto/qml/qmllint/data/groupedScope.qml new file mode 100644 index 0000000000..40f9b41be8 --- /dev/null +++ b/tests/auto/qml/qmllint/data/groupedScope.qml @@ -0,0 +1,7 @@ +import QtQuick 2.0 + +Rectangle { + border.width: 1 + + gradient: Gradient {} +} diff --git a/tests/auto/qml/qmllint/tst_qmllint.cpp b/tests/auto/qml/qmllint/tst_qmllint.cpp index fe6996d6d9..14d1515722 100644 --- a/tests/auto/qml/qmllint/tst_qmllint.cpp +++ b/tests/auto/qml/qmllint/tst_qmllint.cpp @@ -360,6 +360,7 @@ void TestQmllint::cleanQmlCode_data() QTest::newRow("overridescript") << QStringLiteral("overridescript.qml"); QTest::newRow("multiExtension") << QStringLiteral("multiExtension.qml"); QTest::newRow("segFault") << QStringLiteral("SegFault.qml"); + QTest::newRow("grouped scope failure") << QStringLiteral("groupedScope.qml"); } void TestQmllint::cleanQmlCode() -- cgit v1.2.3