From dab0d62b655ce9a476993de2558a573a5066288c Mon Sep 17 00:00:00 2001 From: Dmitry Shachnev Date: Tue, 9 Feb 2021 21:29:49 +0300 Subject: Make tst_qmldiskcache::regenerateAfterChange() pass on big endian systems We cannot use reinterpret_cast here, because testUnit->constants() returns a pointer to quint64_le data, which needs to be converted to native endianness first. Here I used the QV4::Value converter that accepts quint64, so this conversion now happens implicitly. Change-Id: Iff6e3e4554af8890e61cb06e6fd79339c7a14653 Pick-to: 6.0 6.1 Reviewed-by: Ulf Hermann --- tests/auto/qml/qmldiskcache/tst_qmldiskcache.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'tests/auto/qml') diff --git a/tests/auto/qml/qmldiskcache/tst_qmldiskcache.cpp b/tests/auto/qml/qmldiskcache/tst_qmldiskcache.cpp index d96231e81e..593eea3e3a 100644 --- a/tests/auto/qml/qmldiskcache/tst_qmldiskcache.cpp +++ b/tests/auto/qml/qmldiskcache/tst_qmldiskcache.cpp @@ -376,9 +376,8 @@ void tst_qmldiskcache::regenerateAfterChange() QCOMPARE(quint32(obj->nBindings), quint32(2)); QCOMPARE(quint32(obj->bindingTable()->type), quint32(QV4::CompiledData::Binding::Type_Number)); - QCOMPARE(reinterpret_cast(testUnit->constants()) - [obj->bindingTable()->value.constantValueIndex].doubleValue(), - double(42)); + const QV4::Value value(testUnit->constants()[obj->bindingTable()->value.constantValueIndex]); + QCOMPARE(value.doubleValue(), double(42)); QCOMPARE(quint32(testUnit->functionTableSize), quint32(1)); -- cgit v1.2.3