From 2eb2d6386da304cd1164264ae0bff685c796d89c Mon Sep 17 00:00:00 2001 From: Michael Brasser Date: Mon, 23 Oct 2017 20:45:00 -0500 Subject: Prevent errors when unloading Loader Invalidate the context of the object so that destruction is signaled and bindings no longer run. Task-number: QTBUG-47321 Task-number: QTBUG-51995 Task-number: QTBUG-60344 Change-Id: I194a2fefe4e769a58c9ce022d39fe76cbe230de7 Reviewed-by: Michael Brasser --- tests/auto/quick/qquickloader/data/bindings.qml | 71 ++++++++++++++++++++++ .../auto/quick/qquickloader/data/parentErrors.qml | 47 ++++++++++++++ 2 files changed, 118 insertions(+) create mode 100644 tests/auto/quick/qquickloader/data/bindings.qml create mode 100644 tests/auto/quick/qquickloader/data/parentErrors.qml (limited to 'tests/auto/quick/qquickloader/data') diff --git a/tests/auto/quick/qquickloader/data/bindings.qml b/tests/auto/quick/qquickloader/data/bindings.qml new file mode 100644 index 0000000000..e0eae2a3e5 --- /dev/null +++ b/tests/auto/quick/qquickloader/data/bindings.qml @@ -0,0 +1,71 @@ +/**************************************************************************** +** +** Copyright (C) 2017 The Qt Company Ltd. +** Contact: https://www.qt.io/licensing/ +** +** This file is part of the manual tests of the Qt Toolkit. +** +** $QT_BEGIN_LICENSE:GPL-EXCEPT$ +** Commercial License Usage +** Licensees holding valid commercial Qt licenses may use this file in +** accordance with the commercial license agreement provided with the +** Software or, alternatively, in accordance with the terms contained in +** a written agreement between you and The Qt Company. For licensing terms +** and conditions see https://www.qt.io/terms-conditions. For further +** information use the contact form at https://www.qt.io/contact-us. +** +** GNU General Public License Usage +** Alternatively, this file may be used under the terms of the GNU +** General Public License version 3 as published by the Free Software +** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT +** included in the packaging of this file. Please review the following +** information to ensure the GNU General Public License requirements will +** be met: https://www.gnu.org/licenses/gpl-3.0.html. +** +** $QT_END_LICENSE$ +** +****************************************************************************/ + +import QtQuick 2.0 + +Item { + id: root + + property alias game: theGame + property alias loader: theLoader + + Item { + id: theGame + + property bool isReady: false + + onStateChanged: { + if (state == "invalid") { + // The Loader's active property is bound to isReady, so none of its bindings + // should be updated when isReady becomes false + isReady = false; + + player.destroy(); + player = null; + } else if (state == "running") { + player = Qt.createQmlObject("import QtQuick 2.0; Item { property color color: 'black' }", root); + + isReady = true; + } + } + + property Item player + } + + Loader { + id: theLoader + active: theGame.isReady + sourceComponent: Rectangle { + width: 400 + height: 400 + color: game.player.color + + property var game: theGame + } + } +} diff --git a/tests/auto/quick/qquickloader/data/parentErrors.qml b/tests/auto/quick/qquickloader/data/parentErrors.qml new file mode 100644 index 0000000000..36607e7f05 --- /dev/null +++ b/tests/auto/quick/qquickloader/data/parentErrors.qml @@ -0,0 +1,47 @@ +/**************************************************************************** +** +** Copyright (C) 2017 The Qt Company Ltd. +** Contact: https://www.qt.io/licensing/ +** +** This file is part of the manual tests of the Qt Toolkit. +** +** $QT_BEGIN_LICENSE:GPL-EXCEPT$ +** Commercial License Usage +** Licensees holding valid commercial Qt licenses may use this file in +** accordance with the commercial license agreement provided with the +** Software or, alternatively, in accordance with the terms contained in +** a written agreement between you and The Qt Company. For licensing terms +** and conditions see https://www.qt.io/terms-conditions. For further +** information use the contact form at https://www.qt.io/contact-us. +** +** GNU General Public License Usage +** Alternatively, this file may be used under the terms of the GNU +** General Public License version 3 as published by the Free Software +** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT +** included in the packaging of this file. Please review the following +** information to ensure the GNU General Public License requirements will +** be met: https://www.gnu.org/licenses/gpl-3.0.html. +** +** $QT_END_LICENSE$ +** +****************************************************************************/ + +import QtQuick 2.0 + +Rectangle { + width: 360 + height: 360 + + property alias loader: loader + + Loader { + id: loader + anchors.fill: parent + } + + property Component component: Rectangle { + width: parent.width + height: parent.height + color: "pink" + } +} -- cgit v1.2.3