From 525e4ab14b7e7a37c1eb08ecfc92a97d190e23a8 Mon Sep 17 00:00:00 2001 From: Shawn Rutledge Date: Fri, 18 Sep 2020 15:31:18 +0200 Subject: Blacklist tests due to QPointerEvent changes qtbase/2692237bb1b0c0f50b7cc5d920eb8ab065063d47 and the associated Qt Quick change to do direct delivery of QPointerEvents seem to have broken a number of tests as they are currently written. It looks bad; however I spent a lot of time already on some older "basic" tests like tst_qquickwindow, touchmouse, tst_qquickflickable etc. and found a lot of things to fix while doing that; so at least those aren't broken now. Troubleshooting each test takes time. Hopefully it will turn out that many of these failures are related (there seems to be something in common about handlers and items stealing touch grabs from each other). Task-number: QTBUG-86729 Change-Id: I14acf57fc83fa961a25f91108dcd4aea42b54435 Reviewed-by: Shawn Rutledge --- tests/auto/qmltest/events/BLACKLIST | 6 ++++++ tests/auto/quick/pointerhandlers/flickableinterop/BLACKLIST | 7 +++++++ tests/auto/quick/pointerhandlers/mousearea_interop/BLACKLIST | 2 ++ .../pointerhandlers/multipointtoucharea_interop/BLACKLIST | 6 ++++++ tests/auto/quick/pointerhandlers/qquickdraghandler/BLACKLIST | 8 ++++++++ .../auto/quick/pointerhandlers/qquickpinchhandler/BLACKLIST | 2 ++ .../quick/pointerhandlers/qquickpointerhandler/BLACKLIST | 6 ++++++ .../auto/quick/pointerhandlers/qquickpointhandler/BLACKLIST | 6 ++++++ tests/auto/quick/pointerhandlers/qquicktaphandler/BLACKLIST | 10 ++++++++++ .../auto/quick/pointerhandlers/qquickwheelhandler/BLACKLIST | 3 +++ tests/auto/quick/qquickitem/BLACKLIST | 8 ++++++++ tests/auto/quick/qquicklistview/BLACKLIST | 4 ++++ tests/auto/quick/qquickmousearea/BLACKLIST | 12 ++++++++++++ tests/auto/quick/qquickmultipointtoucharea/BLACKLIST | 11 +++++++++++ tests/auto/quick/qquickpathview/BLACKLIST | 2 ++ tests/auto/quick/qquickwindow/BLACKLIST | 2 ++ tests/auto/quickwidgets/qquickwidget/BLACKLIST | 2 ++ 17 files changed, 97 insertions(+) create mode 100644 tests/auto/qmltest/events/BLACKLIST create mode 100644 tests/auto/quick/pointerhandlers/mousearea_interop/BLACKLIST create mode 100644 tests/auto/quick/pointerhandlers/multipointtoucharea_interop/BLACKLIST create mode 100644 tests/auto/quick/pointerhandlers/qquickdraghandler/BLACKLIST create mode 100644 tests/auto/quick/pointerhandlers/qquickpinchhandler/BLACKLIST create mode 100644 tests/auto/quick/pointerhandlers/qquickpointerhandler/BLACKLIST create mode 100644 tests/auto/quick/pointerhandlers/qquickpointhandler/BLACKLIST create mode 100644 tests/auto/quick/pointerhandlers/qquicktaphandler/BLACKLIST create mode 100644 tests/auto/quick/qquickpathview/BLACKLIST (limited to 'tests/auto') diff --git a/tests/auto/qmltest/events/BLACKLIST b/tests/auto/qmltest/events/BLACKLIST new file mode 100644 index 0000000000..4a963e6a8a --- /dev/null +++ b/tests/auto/qmltest/events/BLACKLIST @@ -0,0 +1,6 @@ +[touch::test_childMapping] +* +[touch::test_simpleChain] +* +[touch::test_fullSequence] +* diff --git a/tests/auto/quick/pointerhandlers/flickableinterop/BLACKLIST b/tests/auto/quick/pointerhandlers/flickableinterop/BLACKLIST index 92903955ac..75d596fcab 100644 --- a/tests/auto/quick/pointerhandlers/flickableinterop/BLACKLIST +++ b/tests/auto/quick/pointerhandlers/flickableinterop/BLACKLIST @@ -1,7 +1,14 @@ [touchAndDragHandlerOnFlickable] windows gcc opensuse-leap +* # QTBUG-86729 [touchDragFlickableBehindSlider] windows gcc [touchDragFlickableBehindButton] windows gcc +[dragHandlerInSiblingStealingGrabFromMouseAreaViaTouch] +* # QTBUG-86729 +[mouseDragFlickableBehindButton] +* # QTBUG-86729 +[touchDragFlickableBehindButton] +* # QTBUG-86729 diff --git a/tests/auto/quick/pointerhandlers/mousearea_interop/BLACKLIST b/tests/auto/quick/pointerhandlers/mousearea_interop/BLACKLIST new file mode 100644 index 0000000000..3116160599 --- /dev/null +++ b/tests/auto/quick/pointerhandlers/mousearea_interop/BLACKLIST @@ -0,0 +1,2 @@ +[dragHandlerInSiblingStealingGrabFromMouseAreaViaTouch] +* # QTBUG-86729 diff --git a/tests/auto/quick/pointerhandlers/multipointtoucharea_interop/BLACKLIST b/tests/auto/quick/pointerhandlers/multipointtoucharea_interop/BLACKLIST new file mode 100644 index 0000000000..513f37976b --- /dev/null +++ b/tests/auto/quick/pointerhandlers/multipointtoucharea_interop/BLACKLIST @@ -0,0 +1,6 @@ +[dragHandlerInParentStealingGrabFromItem] +* # QTBUG-86729 +[touchesThenPinch] +* # QTBUG-86729 +[touchDrag] +* # QTBUG-86729 diff --git a/tests/auto/quick/pointerhandlers/qquickdraghandler/BLACKLIST b/tests/auto/quick/pointerhandlers/qquickdraghandler/BLACKLIST new file mode 100644 index 0000000000..e8ceb1c2a7 --- /dev/null +++ b/tests/auto/quick/pointerhandlers/qquickdraghandler/BLACKLIST @@ -0,0 +1,8 @@ +[mouseClickButton] # QTBUG-86729 +* +[touchPassiveGrabbers] +* # QTBUG-86729 +[touchDragMultiSliders] +* # QTBUG-86729 +[snapMode] +* # QTBUG-86729 diff --git a/tests/auto/quick/pointerhandlers/qquickpinchhandler/BLACKLIST b/tests/auto/quick/pointerhandlers/qquickpinchhandler/BLACKLIST new file mode 100644 index 0000000000..9dfa00a2be --- /dev/null +++ b/tests/auto/quick/pointerhandlers/qquickpinchhandler/BLACKLIST @@ -0,0 +1,2 @@ +[scaleThreeFingers] +* # QTBUG-86729 diff --git a/tests/auto/quick/pointerhandlers/qquickpointerhandler/BLACKLIST b/tests/auto/quick/pointerhandlers/qquickpointerhandler/BLACKLIST new file mode 100644 index 0000000000..9a443d66b4 --- /dev/null +++ b/tests/auto/quick/pointerhandlers/qquickpointerhandler/BLACKLIST @@ -0,0 +1,6 @@ +[touchReleaseOutside] +* # QTBUG-86729 +[mouseEventDelivery] +* # QTBUG-86729 +[touchEventDelivery] +* # QTBUG-86729 diff --git a/tests/auto/quick/pointerhandlers/qquickpointhandler/BLACKLIST b/tests/auto/quick/pointerhandlers/qquickpointhandler/BLACKLIST new file mode 100644 index 0000000000..abeff5b725 --- /dev/null +++ b/tests/auto/quick/pointerhandlers/qquickpointhandler/BLACKLIST @@ -0,0 +1,6 @@ +[pressedMultipleButtons] # QTBUG-86729 +* +[singleTouch] +* # QTBUG-86729 +[simultaneousMultiTouch] +* # QTBUG-86729 diff --git a/tests/auto/quick/pointerhandlers/qquicktaphandler/BLACKLIST b/tests/auto/quick/pointerhandlers/qquicktaphandler/BLACKLIST new file mode 100644 index 0000000000..4f25e9ba97 --- /dev/null +++ b/tests/auto/quick/pointerhandlers/qquicktaphandler/BLACKLIST @@ -0,0 +1,10 @@ +[mouseGesturePolicyDragThreshold] # QTBUG-86729 +* +[touchGesturePolicyDragThreshold] +* # QTBUG-86729 +[touchMouseGesturePolicyDragThreshold] +* # QTBUG-86729 +[buttonsMultiTouch] +* # QTBUG-86729 +[componentUserBehavioralOverride] +* # QTBUG-86729 diff --git a/tests/auto/quick/pointerhandlers/qquickwheelhandler/BLACKLIST b/tests/auto/quick/pointerhandlers/qquickwheelhandler/BLACKLIST index 2949d3371f..a189ebe041 100644 --- a/tests/auto/quick/pointerhandlers/qquickwheelhandler/BLACKLIST +++ b/tests/auto/quick/pointerhandlers/qquickwheelhandler/BLACKLIST @@ -1,3 +1,6 @@ # QTBUG-81993 [singleHandler] macos ci +* # QTBUG-86729 +[nestedHandler] +* # QTBUG-86729 diff --git a/tests/auto/quick/qquickitem/BLACKLIST b/tests/auto/quick/qquickitem/BLACKLIST index d94a3ef102..77929d39ce 100644 --- a/tests/auto/quick/qquickitem/BLACKLIST +++ b/tests/auto/quick/qquickitem/BLACKLIST @@ -1,2 +1,10 @@ [contains:hollow square: testing points inside] xcb +[qtBug60123] +* # QTBUG-86729 +[ignoreButtonPressNotInAcceptedMouseButtons] +* # QTBUG-86729 +[touchEventAcceptIgnore] +* # QTBUG-86729 +[mouseGrab] +* # QTBUG-86729 diff --git a/tests/auto/quick/qquicklistview/BLACKLIST b/tests/auto/quick/qquicklistview/BLACKLIST index 6ef69550a4..6e100ef319 100644 --- a/tests/auto/quick/qquicklistview/BLACKLIST +++ b/tests/auto/quick/qquicklistview/BLACKLIST @@ -12,3 +12,7 @@ macos macos opensuse-leap ubuntu-18.04 +[touchCancel] +* # QTBUG-86729 +[parentBinding] +* # QTBUG-86729 diff --git a/tests/auto/quick/qquickmousearea/BLACKLIST b/tests/auto/quick/qquickmousearea/BLACKLIST index 089bb3a873..7769748a5b 100644 --- a/tests/auto/quick/qquickmousearea/BLACKLIST +++ b/tests/auto/quick/qquickmousearea/BLACKLIST @@ -8,3 +8,15 @@ opensuse-leap # QTBUG-82282 [pressOneAndTapAnother] opensuse-leap + +[nestedEventDelivery] +* # QTBUG-86729 + +[notPressedAfterStolenGrab] +* # QTBUG-86729 + +[ignoreBySource] +* # QTBUG-86729 + +[onMousePressRejected] +* # QTBUG-86729 diff --git a/tests/auto/quick/qquickmultipointtoucharea/BLACKLIST b/tests/auto/quick/qquickmultipointtoucharea/BLACKLIST index 6af00ab76f..2c568238a1 100644 --- a/tests/auto/quick/qquickmultipointtoucharea/BLACKLIST +++ b/tests/auto/quick/qquickmultipointtoucharea/BLACKLIST @@ -10,3 +10,14 @@ ubuntu-18.04 opensuse-42.3 opensuse-leap sles +* # QTBUG-86729 +[stationaryTouchWithChangingPressure] # QTBUG-86729 +* +[cancel] +* # QTBUG-86729 +[inFlickable] +* # QTBUG-86729 +[reuse] +* # QTBUG-86729 +[signalTest] +* # QTBUG-86729 diff --git a/tests/auto/quick/qquickpathview/BLACKLIST b/tests/auto/quick/qquickpathview/BLACKLIST new file mode 100644 index 0000000000..b315b8e565 --- /dev/null +++ b/tests/auto/quick/qquickpathview/BLACKLIST @@ -0,0 +1,2 @@ +[cancelDrag] +* # QTBUG-86729 diff --git a/tests/auto/quick/qquickwindow/BLACKLIST b/tests/auto/quick/qquickwindow/BLACKLIST index b4b7d2d761..f6fa443eef 100644 --- a/tests/auto/quick/qquickwindow/BLACKLIST +++ b/tests/auto/quick/qquickwindow/BLACKLIST @@ -1,3 +1,5 @@ [openglContextCreatedSignal] opensuse-42.3 opensuse-leap +[touchEvent_cancelClearsMouseGrab] +macos # QTBUG-86729 diff --git a/tests/auto/quickwidgets/qquickwidget/BLACKLIST b/tests/auto/quickwidgets/qquickwidget/BLACKLIST index 095e9ee484..44ab3e9397 100644 --- a/tests/auto/quickwidgets/qquickwidget/BLACKLIST +++ b/tests/auto/quickwidgets/qquickwidget/BLACKLIST @@ -3,3 +3,5 @@ opensuse-42.3 opensuse-leap [enterLeave] macos +[synthMouseFromTouch] # QTBUG-86729 +* -- cgit v1.2.3