From 03d81887d7edc49bcd76d653a4283336d68b21a6 Mon Sep 17 00:00:00 2001 From: Ulf Hermann Date: Mon, 26 Oct 2020 13:55:52 +0100 Subject: qmllint: Check identifiers before giving up in case of previous errors The identifier check might yet yield more information. Change-Id: I96f700acf257736fea7e9c2023b9e8797f702f7c Reviewed-by: Fabian Kosmale Reviewed-by: Maximilian Goldstein --- tools/qmllint/findwarnings.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'tools') diff --git a/tools/qmllint/findwarnings.cpp b/tools/qmllint/findwarnings.cpp index fc90884d60..653c5bc209 100644 --- a/tools/qmllint/findwarnings.cpp +++ b/tools/qmllint/findwarnings.cpp @@ -339,9 +339,6 @@ bool FindWarningVisitor::check() } } - if (m_visitFailed) - return false; - // now that all ids are known, revisit any Connections whose target were perviously unknown for (auto const &outstandingConnection: m_outstandingConnections) { auto targetScope = m_scopesById[outstandingConnection.targetName]; @@ -361,7 +358,8 @@ bool FindWarningVisitor::check() return true; CheckIdentifiers check(&m_colorOut, m_code, m_rootScopeImports, m_filePath); - return check(m_scopesById, m_signalHandlers, m_memberAccessChains, m_globalScope, m_rootId); + return check(m_scopesById, m_signalHandlers, m_memberAccessChains, m_globalScope, m_rootId) + && !m_visitFailed; } bool FindWarningVisitor::visit(QQmlJS::AST::UiObjectBinding *uiob) -- cgit v1.2.3