From 44342fb446216576e3267af928e3789805cd4690 Mon Sep 17 00:00:00 2001 From: Maximilian Goldstein Date: Mon, 10 May 2021 13:37:20 +0200 Subject: qmllint: Fix unknownBuiltins not being ignored in all cases Previously we only skipped over them when they occurred in a property access chain (not covering the beginning, methods etc.) now we should always ignore them safely. Change-Id: I405de6d97a15cba1db641b2c8310427cc9558d68 Reviewed-by: Fabian Kosmale Reviewed-by: Ulf Hermann --- tools/qmllint/checkidentifiers.cpp | 3 +++ 1 file changed, 3 insertions(+) (limited to 'tools') diff --git a/tools/qmllint/checkidentifiers.cpp b/tools/qmllint/checkidentifiers.cpp index 4cfcaf91d3..66903c29a8 100644 --- a/tools/qmllint/checkidentifiers.cpp +++ b/tools/qmllint/checkidentifiers.cpp @@ -119,6 +119,9 @@ void CheckIdentifiers::checkMemberAccess(const QVector &members, return; } + if (unknownBuiltins.contains(scope->internalName())) + return; + const auto property = scope->property(access.m_name); if (!property.propertyName().isEmpty()) { const auto binding = scope->propertyBinding(access.m_name); -- cgit v1.2.3