From da9d5016613d04f002c6433e2b3083143fec34cb Mon Sep 17 00:00:00 2001 From: Lars Knoll Date: Fri, 13 Jun 2014 16:04:39 +0200 Subject: Fix Managed::as<>() method The as<> casting method was not doing the right thing in 100% of the cases. It only checked if the object in question was exactly of the type being asked for. It however didn't check if the object was derived from the type. This commit fixes this by adding a parent chain to the vtables, that is then being used to check this safely at runtime. Change-Id: I9e0b13adbda668aee8c7451e2bb71cd6d4e316d9 Reviewed-by: Simon Hausmann --- tools/qmljs/main.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tools') diff --git a/tools/qmljs/main.cpp b/tools/qmljs/main.cpp index 50bba820e5..98bf9ad2c5 100644 --- a/tools/qmljs/main.cpp +++ b/tools/qmljs/main.cpp @@ -78,7 +78,7 @@ struct Print: FunctionObject setVTable(staticVTable()); } }; - V4_OBJECT + V4_OBJECT(FunctionObject) static ReturnedValue call(Managed *, CallData *callData) { @@ -105,7 +105,7 @@ struct GC: public FunctionObject } }; - V4_OBJECT + V4_OBJECT(FunctionObject) static ReturnedValue call(Managed *m, CallData *) { -- cgit v1.2.3