/**************************************************************************** ** ** Copyright (C) 2019 The Qt Company Ltd. ** Contact: https://www.qt.io/licensing/ ** ** This file is part of the tools applications of the Qt Toolkit. ** ** $QT_BEGIN_LICENSE:GPL-EXCEPT$ ** Commercial License Usage ** Licensees holding valid commercial Qt licenses may use this file in ** accordance with the commercial license agreement provided with the ** Software or, alternatively, in accordance with the terms contained in ** a written agreement between you and The Qt Company. For licensing terms ** and conditions see https://www.qt.io/terms-conditions. For further ** information use the contact form at https://www.qt.io/contact-us. ** ** GNU General Public License Usage ** Alternatively, this file may be used under the terms of the GNU ** General Public License version 3 as published by the Free Software ** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT ** included in the packaging of this file. Please review the following ** information to ensure the GNU General Public License requirements will ** be met: https://www.gnu.org/licenses/gpl-3.0.html. ** ** $QT_END_LICENSE$ ** ****************************************************************************/ #include "findwarnings.h" #include "importedmembersvisitor.h" #include "scopetree.h" #include "typedescriptionreader.h" #include "checkidentifiers.h" #include "qmljstypereader.h" #include #include #include #include #include #include #include #include static const QString prefixedName(const QString &prefix, const QString &name) { Q_ASSERT(!prefix.endsWith('.')); return prefix.isEmpty() ? name : (prefix + QLatin1Char('.') + name); } static QQmlDirParser createQmldirParserForFile(const QString &filename) { QFile f(filename); f.open(QFile::ReadOnly); QQmlDirParser parser; parser.parse(f.readAll()); return parser; } void FindWarningVisitor::enterEnvironment(ScopeType type, const QString &name) { m_currentScope = ScopeTree::create(type, m_currentScope); m_currentScope->setInternalName(name); } void FindWarningVisitor::leaveEnvironment() { m_currentScope = m_currentScope->parentScope(); } static const QLatin1String SlashQmldir = QLatin1String("/qmldir"); static const QLatin1String SlashPluginsDotQmltypes = QLatin1String("/plugins.qmltypes"); void FindWarningVisitor::Importer::readQmltypes( const QString &filename, QHash *objects) { const QFileInfo fileInfo(filename); if (!fileInfo.exists()) { m_warnings.append(QLatin1String("QML types file does not exist: ") + filename); return; } if (fileInfo.isDir()) { m_warnings.append(QLatin1String("QML types file cannot be a directory: ") + filename); return; } QFile file(filename); file.open(QFile::ReadOnly); TypeDescriptionReader reader { filename, file.readAll() }; QStringList dependencies; auto succ = reader(objects, &dependencies); if (!succ) m_warnings.append(reader.errorMessage()); } FindWarningVisitor::Importer::Import FindWarningVisitor::Importer::readQmldir(const QString &path) { Import result; auto reader = createQmldirParserForFile(path + SlashQmldir); result.imports.append(reader.imports()); result.dependencies.append(reader.dependencies()); QHash qmlComponents; const auto components = reader.components(); for (auto it = components.begin(), end = components.end(); it != end; ++it) { const QString filePath = path + QLatin1Char('/') + it->fileName; if (!QFile::exists(filePath)) { m_warnings.append(it->fileName + QLatin1String(" is listed as component in ") + path + SlashQmldir + QLatin1String(" but does not exist.\n")); continue; } auto mo = qmlComponents.find(it.key()); if (mo == qmlComponents.end()) mo = qmlComponents.insert(it.key(), localFile2ScopeTree(filePath)); (*mo)->addExport( it.key(), reader.typeNamespace(), ComponentVersion(it->version)); } for (auto it = qmlComponents.begin(), end = qmlComponents.end(); it != end; ++it) result.objects.insert(it.key(), it.value()); if (!reader.plugins().isEmpty() && QFile::exists(path + SlashPluginsDotQmltypes)) readQmltypes(path + SlashPluginsDotQmltypes, &result.objects); const auto scripts = reader.scripts(); for (const auto &script : scripts) { const QString filePath = path + QLatin1Char('/') + script.fileName; result.scripts.push_back({ script.nameSpace, localFile2ScopeTree(filePath) }); } return result; } void FindWarningVisitor::Importer::processImport( const QString &prefix, const FindWarningVisitor::Importer::Import &import, QTypeRevision version) { // Import the dependencies with an invalid prefix. The prefix will never be matched by actual // QML code but the C++ types will be visible. const QString invalidPrefix = QString::fromLatin1("$dependency$"); for (auto const &dependency : qAsConst(import.dependencies)) importHelper(dependency.module, invalidPrefix, dependency.version); for (auto const &import : qAsConst(import.imports)) { importHelper(import.module, prefix, import.isAutoImport ? version : import.version); } for (const auto &it : qAsConst(import.scripts)) { m_exportedName2Scope.importedQmlNames.insert(prefixedName(prefix, it.first), it.second); m_exportedName2Scope.exportedQmlNames.insert(it.first, it.second); } // add objects for (auto it = import.objects.begin(); it != import.objects.end(); ++it) { const auto &val = it.value(); m_exportedName2Scope.cppNames.insert(val->internalName(), val); const auto exports = val->exports(); for (const auto &valExport : exports) { m_exportedName2Scope.importedQmlNames.insert(prefixedName(prefix, valExport.type()), val); m_exportedName2Scope.exportedQmlNames.insert(valExport.type(), val); } } } FindWarningVisitor::ImportedTypes FindWarningVisitor::Importer::importBareQmlTypes( const QStringList &qmltypesFiles) { ImportedTypes result; qSwap(result, m_exportedName2Scope); for (auto const &dir : m_importPaths) { Import result; QDirIterator it { dir, QStringList() << QLatin1String("builtins.qmltypes"), QDir::NoFilter, QDirIterator::Subdirectories }; while (it.hasNext()) readQmltypes(it.next(), &result.objects); processImport("", result, QTypeRevision()); } if (qmltypesFiles.isEmpty()) { for (auto const &qmltypesPath : m_importPaths) { if (QFile::exists(qmltypesPath + SlashQmldir)) continue; Import result; QDirIterator it { qmltypesPath, QStringList { QLatin1String("*.qmltypes") }, QDir::Files }; while (it.hasNext()) { const QString name = it.next(); if (!name.endsWith(QLatin1String("/builtins.qmltypes"))) readQmltypes(name, &result.objects); } processImport("", result, QTypeRevision()); } } else { Import result; for (const auto &qmltypeFile : qmltypesFiles) readQmltypes(qmltypeFile, &result.objects); processImport("", result, QTypeRevision()); } qSwap(result, m_exportedName2Scope); return result; } FindWarningVisitor::ImportedTypes FindWarningVisitor::Importer::importModule( const QString &module, const QString &prefix, QTypeRevision version) { ImportedTypes result; qSwap(result, m_exportedName2Scope); importHelper(module, prefix, version); qSwap(result, m_exportedName2Scope); return result; } void FindWarningVisitor::Importer::importHelper( const QString &module, const QString &prefix, QTypeRevision version) { const QPair importId { module, prefix }; if (m_seenImports.contains(importId)) return; m_seenImports.insert(importId); const auto qmltypesPaths = qQmlResolveImportPaths(module, m_importPaths, version); for (auto const &qmltypesPath : qmltypesPaths) { if (QFile::exists(qmltypesPath + SlashQmldir)) { processImport(prefix, readQmldir(qmltypesPath), version); break; } } } ScopeTree::Ptr FindWarningVisitor::Importer::localFile2ScopeTree(const QString &filePath) { QmlJSTypeReader typeReader(filePath); ScopeTree::Ptr result = typeReader(); const QStringList errors = typeReader.errors(); for (const QString &error : errors) m_warnings.append(error); const auto imports = typeReader.imports(); for (const auto &import : imports) importHelper(import.module, import.prefix, import.version); return result; } FindWarningVisitor::ImportedTypes FindWarningVisitor::Importer::importFileOrDirectory( const QString &fileOrDirectory, const QString &prefix) { ImportedTypes result; qSwap(result, m_exportedName2Scope); QString name = fileOrDirectory; if (QFileInfo(name).isRelative()) name = QDir(m_currentDir).filePath(name); if (QFileInfo(name).isFile()) { ScopeTree::Ptr scope(localFile2ScopeTree(name)); m_exportedName2Scope.importedQmlNames.insert( prefix.isEmpty() ? scope->internalName() : prefix, scope); m_exportedName2Scope.exportedQmlNames.insert(scope->internalName(), scope); qSwap(result, m_exportedName2Scope); return result; } QDirIterator it { name, QStringList() << QLatin1String("*.qml"), QDir::NoFilter }; while (it.hasNext()) { ScopeTree::Ptr scope(localFile2ScopeTree(it.next())); if (!scope->internalName().isEmpty()) { m_exportedName2Scope.importedQmlNames.insert(prefixedName(prefix, scope->internalName()), scope); m_exportedName2Scope.exportedQmlNames.insert(scope->internalName(), scope); } } qSwap(result, m_exportedName2Scope); return result; } void FindWarningVisitor::importExportedNames(QStringView prefix, QString name) { QList scopes; ScopeTree::ConstPtr scope = m_rootScopeImports.importedQmlNames.value( m_rootScopeImports.importedQmlNames.contains(name) ? name : prefix + QLatin1Char('.') + name); for (;;) { if (scope) { if (scopes.contains(scope)) { QString inheritenceCycle = name; for (const auto &seen: qAsConst(scopes)) { inheritenceCycle.append(QLatin1String(" -> ")); inheritenceCycle.append(seen->baseTypeName()); } if (m_warnInheritanceCycle) { m_colorOut.write(QLatin1String("Warning: "), Warning); m_colorOut.write(QString::fromLatin1("%1 is part of an inheritance cycle: %2\n") .arg(name) .arg(inheritenceCycle)); } m_unknownImports.insert(name); m_visitFailed = true; break; } scopes.append(scope); const auto properties = scope->properties(); for (auto property : properties) { property.setType(scope->isComposite() ? m_rootScopeImports.importedQmlNames.value(property.typeName()) : m_rootScopeImports.cppNames.value(property.typeName())); m_currentScope->insertPropertyIdentifier(property); } m_currentScope->addMethods(scope->methods()); name = scope->baseTypeName(); if (name.isEmpty() || name == QLatin1String("QObject")) break; scope = scope->isComposite() ? m_rootScopeImports.importedQmlNames.value(name) : m_rootScopeImports.cppNames.value(name); } else { m_colorOut.write(QLatin1String("warning: "), Warning); m_colorOut.write(name + QLatin1String(" was not found." " Did you add all import paths?\n")); m_unknownImports.insert(name); m_visitFailed = true; break; } } } void FindWarningVisitor::throwRecursionDepthError() { m_colorOut.write(QStringLiteral("Error"), Error); m_colorOut.write(QStringLiteral("Maximum statement or expression depth exceeded"), Error); m_visitFailed = true; } bool FindWarningVisitor::visit(QQmlJS::AST::UiProgram *) { enterEnvironment(ScopeType::QMLScope, "program"); m_rootScopeImports = m_importer.importBareQmlTypes(m_qmltypesFiles); // add "self" (as we only ever check the first part of a qualified identifier, we get away with // using an empty ScopeTree m_rootScopeImports.importedQmlNames.insert(QFileInfo { m_filePath }.baseName(), {}); const auto imported = m_importer.importFileOrDirectory("."); m_rootScopeImports.importedQmlNames.insert(imported.importedQmlNames); m_rootScopeImports.cppNames.insert(imported.cppNames); const QStringList warnings = m_importer.takeWarnings(); for (const QString &warning : warnings) { m_colorOut.write(QStringLiteral("warning: "), Warning); m_colorOut.writeUncolored(warning); } return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::UiProgram *) { leaveEnvironment(); } bool FindWarningVisitor::visit(QQmlJS::AST::ClassExpression *ast) { enterEnvironment(ScopeType::JSFunctionScope, ast->name.toString()); return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::ClassExpression *) { leaveEnvironment(); } bool FindWarningVisitor::visit(QQmlJS::AST::ClassDeclaration *ast) { enterEnvironment(ScopeType::JSFunctionScope, ast->name.toString()); return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::ClassDeclaration *) { leaveEnvironment(); } bool FindWarningVisitor::visit(QQmlJS::AST::ForStatement *) { enterEnvironment(ScopeType::JSLexicalScope, "forloop"); return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::ForStatement *) { leaveEnvironment(); } bool FindWarningVisitor::visit(QQmlJS::AST::ForEachStatement *) { enterEnvironment(ScopeType::JSLexicalScope, "foreachloop"); return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::ForEachStatement *) { leaveEnvironment(); } bool FindWarningVisitor::visit(QQmlJS::AST::Block *) { enterEnvironment(ScopeType::JSLexicalScope, "block"); return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::Block *) { leaveEnvironment(); } bool FindWarningVisitor::visit(QQmlJS::AST::CaseBlock *) { enterEnvironment(ScopeType::JSLexicalScope, "case"); return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::CaseBlock *) { leaveEnvironment(); } bool FindWarningVisitor::visit(QQmlJS::AST::Catch *catchStatement) { enterEnvironment(ScopeType::JSLexicalScope, "catch"); m_currentScope->insertJSIdentifier(catchStatement->patternElement->bindingIdentifier.toString(), ScopeType::JSLexicalScope); return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::Catch *) { leaveEnvironment(); } bool FindWarningVisitor::visit(QQmlJS::AST::WithStatement *withStatement) { if (m_warnWithStatement) { m_colorOut.write(QString::fromLatin1("Warning: "), Warning); m_colorOut.write(QString::fromLatin1( "%1:%2: with statements are strongly discouraged in QML " "and might cause false positives when analysing unqalified identifiers\n") .arg(withStatement->firstSourceLocation().startLine) .arg(withStatement->firstSourceLocation().startColumn), Normal); } enterEnvironment(ScopeType::JSLexicalScope, "with"); return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::WithStatement *) { leaveEnvironment(); } static QString signalName(QStringView handlerName) { if (handlerName.startsWith(u"on") && handlerName.size() > 2) { QString signal = handlerName.mid(2).toString(); for (int i = 0; i < signal.length(); ++i) { QChar &ch = signal[i]; if (ch.isLower()) return QString(); if (ch.isUpper()) { ch = ch.toLower(); return signal; } } } return QString(); } bool FindWarningVisitor::visit(QQmlJS::AST::UiScriptBinding *uisb) { using namespace QQmlJS::AST; auto name = uisb->qualifiedId->name; if (name == QLatin1String("id")) { // found id auto expstat = cast(uisb->statement); auto identexp = cast(expstat->expression); m_qmlid2scope.insert(identexp->name.toString(), m_currentScope); if (m_currentScope->isVisualRootScope()) m_rootId = identexp->name.toString(); } else { const QString signal = signalName(name); if (signal.isEmpty()) return true; if (!m_currentScope->methods().contains(signal)) { m_currentScope->addUnmatchedSignalHandler(name.toString(), uisb->firstSourceLocation()); return true; } const auto statement = uisb->statement; if (statement->kind == Node::Kind::Kind_ExpressionStatement) { if (cast(statement)->expression->asFunctionDefinition()) { // functions are already handled // they do not get names inserted according to the signal, but access their formal // parameters return true; } } const auto methods = m_currentScope->methods(); const auto methodsRange = methods.equal_range(signal); for (auto method = methodsRange.first; method != methodsRange.second; ++method) { if (method->methodType() != MetaMethod::Signal) continue; for (auto const ¶m : method->parameterNames()) { const auto firstSourceLocation = statement->firstSourceLocation(); bool hasMultilineStatementBody = statement->lastSourceLocation().startLine > firstSourceLocation.startLine; m_currentScope->insertSignalIdentifier(param, *method, firstSourceLocation, hasMultilineStatementBody); } } return true; } return true; } bool FindWarningVisitor::visit(QQmlJS::AST::UiPublicMember *uipm) { if (uipm->type == QQmlJS::AST::UiPublicMember::Signal) { MetaMethod method; method.setMethodType(MetaMethod::Signal); method.setMethodName(uipm->name.toString()); QQmlJS::AST::UiParameterList *param = uipm->parameters; while (param) { method.addParameter(param->name.toString(), param->type->name.toString()); param = param->next; } m_currentScope->addMethod(method); } else { // property bool inactive: !active // extract name inactive MetaProperty property( uipm->name.toString(), // TODO: complex types etc. uipm->memberType ? uipm->memberType->name.toString() : QString(), uipm->typeModifier == QLatin1String("list"), !uipm->isReadonlyMember, false, uipm->memberType ? (uipm->memberType->name == QLatin1String("alias")) : false, 0); property.setType(m_rootScopeImports.importedQmlNames.value(property.typeName())); m_currentScope->insertPropertyIdentifier(property); } return true; } bool FindWarningVisitor::visit(QQmlJS::AST::IdentifierExpression *idexp) { auto name = idexp->name; m_currentScope->addIdToAccessed(name.toString(), idexp->firstSourceLocation()); m_fieldMemberBase = idexp; return true; } FindWarningVisitor::FindWarningVisitor( QStringList qmltypeDirs, QStringList qmltypesFiles, QString code, QString fileName, bool silent, bool warnUnqualified, bool warnWithStatement, bool warnInheritanceCycle) : m_rootScope(ScopeTree::create(ScopeType::JSFunctionScope)), m_qmltypesFiles(std::move(qmltypesFiles)), m_code(std::move(code)), m_rootId(QLatin1String("")), m_filePath(std::move(fileName)), m_colorOut(silent), m_warnUnqualified(warnUnqualified), m_warnWithStatement(warnWithStatement), m_warnInheritanceCycle(warnInheritanceCycle), m_importer(QFileInfo(m_filePath).path(), qmltypeDirs) { m_rootScope->setInternalName("global"); m_currentScope = m_rootScope; // setup color output m_colorOut.insertMapping(Error, ColorOutput::RedForeground); m_colorOut.insertMapping(Warning, ColorOutput::PurpleForeground); m_colorOut.insertMapping(Info, ColorOutput::BlueForeground); m_colorOut.insertMapping(Normal, ColorOutput::DefaultColor); m_colorOut.insertMapping(Hint, ColorOutput::GreenForeground); QLatin1String jsGlobVars[] = { /* Not listed on the MDN page; browser and QML extensions: */ // console/debug api QLatin1String("console"), QLatin1String("print"), // garbage collector QLatin1String("gc"), // i18n QLatin1String("qsTr"), QLatin1String("qsTrId"), QLatin1String("QT_TR_NOOP"), QLatin1String("QT_TRANSLATE_NOOP"), QLatin1String("QT_TRID_NOOP"), // XMLHttpRequest QLatin1String("XMLHttpRequest") }; for (const char **globalName = QV4::Compiler::Codegen::s_globalNames; *globalName != nullptr; ++globalName) { m_currentScope->insertJSIdentifier(QString::fromLatin1(*globalName), ScopeType::JSLexicalScope); } for (const auto& jsGlobVar: jsGlobVars) m_currentScope->insertJSIdentifier(jsGlobVar, ScopeType::JSLexicalScope); } bool FindWarningVisitor::check() { if (m_visitFailed) return false; // now that all ids are known, revisit any Connections whose target were perviously unknown for (auto const &outstandingConnection: m_outstandingConnections) { auto targetScope = m_qmlid2scope[outstandingConnection.targetName]; if (outstandingConnection.scope && targetScope != nullptr) outstandingConnection.scope->addMethods(targetScope->methods()); QScopedValueRollback rollback(m_currentScope, outstandingConnection.scope); outstandingConnection.uiod->initializer->accept(this); } if (!m_warnUnqualified) return true; CheckIdentifiers check(&m_colorOut, m_code, m_rootScopeImports.importedQmlNames, m_filePath); return check(m_qmlid2scope, m_rootScope, m_rootId); } bool FindWarningVisitor::visit(QQmlJS::AST::VariableDeclarationList *vdl) { while (vdl) { m_currentScope->insertJSIdentifier( vdl->declaration->bindingIdentifier.toString(), (vdl->declaration->scope == QQmlJS::AST::VariableScope::Var) ? ScopeType::JSFunctionScope : ScopeType::JSLexicalScope); vdl = vdl->next; } return true; } void FindWarningVisitor::visitFunctionExpressionHelper(QQmlJS::AST::FunctionExpression *fexpr) { using namespace QQmlJS::AST; auto name = fexpr->name.toString(); if (!name.isEmpty()) { if (m_currentScope->scopeType() == ScopeType::QMLScope) m_currentScope->addMethod(MetaMethod(name, QLatin1String("void"))); else m_currentScope->insertJSIdentifier(name, ScopeType::JSLexicalScope); enterEnvironment(ScopeType::JSFunctionScope, name); } else { enterEnvironment(ScopeType::JSFunctionScope, QLatin1String("")); } } bool FindWarningVisitor::visit(QQmlJS::AST::FunctionExpression *fexpr) { visitFunctionExpressionHelper(fexpr); return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::FunctionExpression *) { leaveEnvironment(); } bool FindWarningVisitor::visit(QQmlJS::AST::FunctionDeclaration *fdecl) { visitFunctionExpressionHelper(fdecl); return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::FunctionDeclaration *) { leaveEnvironment(); } bool FindWarningVisitor::visit(QQmlJS::AST::FormalParameterList *fpl) { for (auto const &boundName : fpl->boundNames()) m_currentScope->insertJSIdentifier(boundName.id, ScopeType::JSLexicalScope); return true; } bool FindWarningVisitor::visit(QQmlJS::AST::UiImport *import) { // construct path QString prefix = QLatin1String(""); if (import->asToken.isValid()) { prefix += import->importId; } auto dirname = import->fileName.toString(); if (!dirname.isEmpty()) { const auto imported = m_importer.importFileOrDirectory(dirname, prefix); m_rootScopeImports.importedQmlNames.insert(imported.importedQmlNames); m_rootScopeImports.cppNames.insert(imported.cppNames); } QString path {}; if (!import->importId.isEmpty()) { // TODO: do not put imported ids into the same space as qml IDs const QString importId = import->importId.toString(); m_qmlid2scope.insert(importId, m_rootScopeImports.importedQmlNames.value(importId)); } auto uri = import->importUri; while (uri) { path.append(uri->name); path.append("/"); uri = uri->next; } path.chop(1); const auto imported = m_importer.importModule( path, prefix, import->version ? import->version->version : QTypeRevision()); m_rootScopeImports.importedQmlNames.insert(imported.importedQmlNames); m_rootScopeImports.cppNames.insert(imported.cppNames); const QStringList warnings = m_importer.takeWarnings(); for (const QString &warning : warnings) { m_colorOut.write(QStringLiteral("warning: "), Warning); m_colorOut.writeUncolored(warning); } return true; } bool FindWarningVisitor::visit(QQmlJS::AST::UiEnumDeclaration *uied) { MetaEnum qmlEnum(uied->name.toString()); for (const auto *member = uied->members; member; member = member->next) qmlEnum.addKey(member->member.toString()); m_currentScope->addEnum(qmlEnum); return true; } bool FindWarningVisitor::visit(QQmlJS::AST::UiObjectBinding *uiob) { // property QtObject __styleData: QtObject {...} QString name {}; auto id = uiob->qualifiedTypeNameId; QStringView prefix = uiob->qualifiedTypeNameId->name; while (id) { name += id->name.toString() + QLatin1Char('.'); id = id->next; } name.chop(1); MetaProperty prop(uiob->qualifiedId->name.toString(), name, false, true, true, name == QLatin1String("alias"), 0); prop.setType(m_rootScopeImports.importedQmlNames.value(uiob->qualifiedTypeNameId->name.toString())); m_currentScope->addProperty(prop); enterEnvironment(ScopeType::QMLScope, name); importExportedNames(prefix, name); return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::UiObjectBinding *uiob) { const auto childScope = m_currentScope; leaveEnvironment(); MetaProperty property(uiob->qualifiedId->name.toString(), uiob->qualifiedTypeNameId->name.toString(), false, true, true, uiob->qualifiedTypeNameId->name == QLatin1String("alias"), 0); property.setType(childScope); m_currentScope->addProperty(property); } bool FindWarningVisitor::visit(QQmlJS::AST::UiObjectDefinition *uiod) { using namespace QQmlJS::AST; QString name {}; auto id = uiod->qualifiedTypeNameId; QStringView prefix = uiod->qualifiedTypeNameId->name; while (id) { name += id->name.toString() + QLatin1Char('.'); id = id->next; } name.chop(1); enterEnvironment(ScopeType::QMLScope, name); if (name.isLower()) return false; // Ignore grouped properties for now importExportedNames(prefix, name); if (name.endsWith("Connections")) { QString target; auto member = uiod->initializer->members; while (member) { if (member->member->kind == QQmlJS::AST::Node::Kind_UiScriptBinding) { auto asBinding = static_cast(member->member); if (asBinding->qualifiedId->name == QLatin1String("target")) { if (asBinding->statement->kind == QQmlJS::AST::Node::Kind_ExpressionStatement) { auto expr = static_cast(asBinding->statement)->expression; if (auto idexpr = QQmlJS::AST::cast(expr)) { target = idexpr->name.toString(); } else { // more complex expressions are not supported } } break; } } member = member->next; } ScopeTree::ConstPtr targetScope; if (target.isEmpty()) { // no target set, connection comes from parentF ScopeTree::Ptr scope = m_currentScope; do { scope = scope->parentScope(); // TODO: rename method } while (scope->scopeType() != ScopeType::QMLScope); targetScope = m_rootScopeImports.importedQmlNames.value(scope->internalName()); } else { // there was a target, check if we already can find it auto scopeIt = m_qmlid2scope.find(target); if (scopeIt != m_qmlid2scope.end()) { targetScope = *scopeIt; } else { m_outstandingConnections.push_back({target, m_currentScope, uiod}); return false; // visit children later once target is known } } if (targetScope) m_currentScope->addMethods(targetScope->methods()); } return true; } bool FindWarningVisitor::visit(QQmlJS::AST::PatternElement *element) { if (element->isVariableDeclaration()) { QQmlJS::AST::BoundNames names; element->boundNames(&names); for (const auto &name : names) { m_currentScope->insertJSIdentifier( name.id, (element->scope == QQmlJS::AST::VariableScope::Var) ? ScopeType::JSFunctionScope : ScopeType::JSLexicalScope); } } return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::UiObjectDefinition *) { auto childScope = m_currentScope; leaveEnvironment(); childScope->updateParentProperty(m_currentScope); } bool FindWarningVisitor::visit(QQmlJS::AST::FieldMemberExpression *) { return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::FieldMemberExpression *fieldMember) { using namespace QQmlJS::AST; ExpressionNode *base = fieldMember->base; while (auto *nested = cast(base)) base = nested->expression; if (m_fieldMemberBase == base) { QString type; if (auto *binary = cast(base)) { if (binary->op == QSOperator::As) { if (auto *right = cast(binary->right)) type = right->m_type->toString(); } } m_currentScope->accessMember(fieldMember->name.toString(), type, fieldMember->identifierToken); m_fieldMemberBase = fieldMember; } else { m_fieldMemberBase = nullptr; } } bool FindWarningVisitor::visit(QQmlJS::AST::BinaryExpression *) { return true; } void FindWarningVisitor::endVisit(QQmlJS::AST::BinaryExpression *binExp) { if (binExp->op == QSOperator::As && m_fieldMemberBase == binExp->left) m_fieldMemberBase = binExp; else m_fieldMemberBase = nullptr; }