1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
|
/****************************************************************************
**
** Copyright (C) 2016 basysKom GmbH.
** Contact: https://www.qt.io/licensing/
**
** This file is part of the test suite of the Qt Toolkit.
**
** $QT_BEGIN_LICENSE:GPL-EXCEPT$
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
** $QT_END_LICENSE$
**
****************************************************************************/
#include <qtest.h>
#include <QQmlEngine>
#include <private/qv4identifiertable_p.h>
class tst_qv4identifiertable : public QObject
{
Q_OBJECT
private slots:
void sweepFirstEntryInBucket();
void sweepCenterEntryInBucket();
void sweepLastEntryInBucket();
void sweepFirstEntryInSameBucketWithDifferingHash();
void dontSweepAcrossBucketBoundaries();
void sweepAcrossBucketBoundariesIfFirstBucketFull();
void sweepBucketGap();
};
void tst_qv4identifiertable::sweepFirstEntryInBucket()
{
QV4::ExecutionEngine engine;
QV4::IdentifierTable table(&engine, /*numBits*/1);
auto entry1 = engine.newString(QStringLiteral("one"));
auto entry2 = engine.newString(QStringLiteral("two"));
auto entry3 = engine.newString(QStringLiteral("three"));
entry1->createHashValue();
entry2->createHashValue();
entry3->createHashValue();
// All strings go into the same bucket
entry1->stringHash = 0;
entry2->stringHash = 0;
entry3->stringHash = 0;
// trigger insertion
table.asPropertyKey(entry1);
table.asPropertyKey(entry2);
table.asPropertyKey(entry3);
QCOMPARE(table.size, 3u);
QCOMPARE(table.alloc, 5u);
QCOMPARE(table.entriesByHash[0], entry1);
QCOMPARE(table.entriesByHash[1], entry2);
QCOMPARE(table.entriesByHash[2], entry3);
QCOMPARE(table.entriesByHash[3], nullptr);
// first entry not marked
entry2->setMarkBit();
entry3->setMarkBit();
table.sweep();
QCOMPARE(table.entriesByHash[0], entry2);
QCOMPARE(table.entriesByHash[1], entry3);
QCOMPARE(table.entriesByHash[2], nullptr);
QCOMPARE(table.entriesByHash[3], nullptr);
}
void tst_qv4identifiertable::sweepCenterEntryInBucket()
{
QV4::ExecutionEngine engine;
QV4::IdentifierTable table(&engine, /*numBits*/1);
auto entry1 = engine.newString(QStringLiteral("one"));
auto entry2 = engine.newString(QStringLiteral("two"));
auto entry3 = engine.newString(QStringLiteral("three"));
entry1->createHashValue();
entry2->createHashValue();
entry3->createHashValue();
// All strings go into the same bucket
entry1->stringHash = 0;
entry2->stringHash = 0;
entry3->stringHash = 0;
// trigger insertion
table.asPropertyKey(entry1);
table.asPropertyKey(entry2);
table.asPropertyKey(entry3);
QCOMPARE(table.size, 3);
QCOMPARE(table.alloc, 5);
QCOMPARE(table.entriesByHash[0], entry1);
QCOMPARE(table.entriesByHash[1], entry2);
QCOMPARE(table.entriesByHash[2], entry3);
QCOMPARE(table.entriesByHash[3], nullptr);
entry1->setMarkBit();
// second entry not marked
entry3->setMarkBit();
table.sweep();
QCOMPARE(table.entriesByHash[0], entry1);
QCOMPARE(table.entriesByHash[1], entry3);
QCOMPARE(table.entriesByHash[2], nullptr);
QCOMPARE(table.entriesByHash[3], nullptr);
}
void tst_qv4identifiertable::sweepLastEntryInBucket()
{
QV4::ExecutionEngine engine;
QV4::IdentifierTable table(&engine, /*numBits*/1);
auto entry1 = engine.newString(QStringLiteral("one"));
auto entry2 = engine.newString(QStringLiteral("two"));
auto entry3 = engine.newString(QStringLiteral("three"));
entry1->createHashValue();
entry2->createHashValue();
entry3->createHashValue();
// All strings go into the same bucket
entry1->stringHash = 0;
entry2->stringHash = 0;
entry3->stringHash = 0;
// trigger insertion
table.asPropertyKey(entry1);
table.asPropertyKey(entry2);
table.asPropertyKey(entry3);
QCOMPARE(table.size, 3);
QCOMPARE(table.alloc, 5);
QCOMPARE(table.entriesByHash[0], entry1);
QCOMPARE(table.entriesByHash[1], entry2);
QCOMPARE(table.entriesByHash[2], entry3);
QCOMPARE(table.entriesByHash[3], nullptr);
entry1->setMarkBit();
entry2->setMarkBit();
// third entry not marked
table.sweep();
QCOMPARE(table.entriesByHash[0], entry1);
QCOMPARE(table.entriesByHash[1], entry2);
QCOMPARE(table.entriesByHash[2], nullptr);
QCOMPARE(table.entriesByHash[3], nullptr);
}
void tst_qv4identifiertable::sweepFirstEntryInSameBucketWithDifferingHash()
{
QV4::ExecutionEngine engine;
QV4::IdentifierTable table(&engine, /*numBits*/1);
auto entry1 = engine.newString(QStringLiteral("one"));
auto entry2 = engine.newString(QStringLiteral("two"));
entry1->createHashValue();
entry2->createHashValue();
// First and second entry have differing hash but end up in the
// same bucket after modulo alloc.
entry1->stringHash = 0;
entry2->stringHash = 5;
// trigger insertion
table.asPropertyKey(entry1);
table.asPropertyKey(entry2);
QCOMPARE(table.size, 2);
QCOMPARE(table.alloc, 5);
QCOMPARE(table.entriesByHash[0], entry1);
QCOMPARE(table.entriesByHash[1], entry2);
QCOMPARE(table.entriesByHash[2], nullptr);
// first entry not marked
entry2->setMarkBit();
table.sweep();
QCOMPARE(table.entriesByHash[0], entry2);
QCOMPARE(table.entriesByHash[1], nullptr);
QCOMPARE(table.entriesByHash[2], nullptr);
}
void tst_qv4identifiertable::dontSweepAcrossBucketBoundaries()
{
QV4::ExecutionEngine engine;
QV4::IdentifierTable table(&engine, /*numBits*/1);
auto entry1 = engine.newString(QStringLiteral("one"));
auto entry2 = engine.newString(QStringLiteral("two"));
auto entry3 = engine.newString(QStringLiteral("three"));
entry1->createHashValue();
entry2->createHashValue();
entry3->createHashValue();
// Different buckets for both entries.
entry1->stringHash = 0;
entry2->stringHash = 1;
// trigger insertion
table.asPropertyKey(entry1);
table.asPropertyKey(entry2);
QCOMPARE(table.size, 2);
QCOMPARE(table.alloc, 5);
QCOMPARE(table.entriesByHash[0], entry1);
QCOMPARE(table.entriesByHash[1], entry2);
QCOMPARE(table.entriesByHash[2], nullptr);
// first entry not marked
entry2->setMarkBit();
table.sweep();
QCOMPARE(table.entriesByHash[0], nullptr);
QCOMPARE(table.entriesByHash[1], entry2);
QCOMPARE(table.entriesByHash[2], nullptr);
}
void tst_qv4identifiertable::sweepAcrossBucketBoundariesIfFirstBucketFull()
{
QV4::ExecutionEngine engine;
QV4::IdentifierTable table(&engine, /*numBits*/3);
auto entry1 = engine.newString(QStringLiteral("one"));
auto entry2 = engine.newString(QStringLiteral("two"));
auto entry3 = engine.newString(QStringLiteral("three"));
auto entry4 = engine.newString(QStringLiteral("four"));
entry1->createHashValue();
entry2->createHashValue();
entry3->createHashValue();
entry4->createHashValue();
// First, third and fourth entry have the same bucket (after modulo) and
// would typically end up in order [entry1, entry3, entry4, entry2]. However
// since null termination isn't guaranteed, an insertion order of
// entry1, entry2, entry3 and entry4 results in a
// table [entry1, entry2, entry3, entry4].
entry1->stringHash = 0;
entry2->stringHash = 1;
entry3->stringHash = 11;
entry4->stringHash = 11;
// trigger insertion
table.asPropertyKey(entry1);
table.asPropertyKey(entry2);
table.asPropertyKey(entry3);
table.asPropertyKey(entry4);
QCOMPARE(table.size, 4);
QCOMPARE(table.alloc, 11);
QCOMPARE(table.entriesByHash[0], entry1);
QCOMPARE(table.entriesByHash[1], entry2);
QCOMPARE(table.entriesByHash[2], entry3);
QCOMPARE(table.entriesByHash[3], entry4);
QCOMPARE(table.entriesByHash[4], nullptr);
// first entry not marked
entry2->setMarkBit();
entry3->setMarkBit();
entry4->setMarkBit();
table.sweep();
QCOMPARE(table.entriesByHash[0], entry3);
QCOMPARE(table.entriesByHash[1], entry2);
QCOMPARE(table.entriesByHash[2], entry4);
QCOMPARE(table.entriesByHash[3], nullptr);
}
void tst_qv4identifiertable::sweepBucketGap()
{
QV4::ExecutionEngine engine;
QV4::IdentifierTable table(&engine, /*numBits*/3);
auto entry1 = engine.newString(QStringLiteral("one"));
auto entry2 = engine.newString(QStringLiteral("two"));
auto entry3 = engine.newString(QStringLiteral("three"));
auto entry4 = engine.newString(QStringLiteral("four"));
entry1->createHashValue();
entry2->createHashValue();
entry3->createHashValue();
entry4->createHashValue();
// We have two buckets where the second entry in the first bucket
// flows into the second bucket. So insertion into the second bucket
// will shift by one and create
// [entry1][entry2 (would map to first but overflows into second), entry3, entry4]
// Garbage collecting the first entry should not only move the second entry
// into its own first bucket (where there is space now), it is also critical to
// not leave a gap but move the third and fourth entries to the beginning of
// their bucket:
// [entry2][entry3, entry4]
entry1->stringHash = 0; // % 11 -> 0
entry2->stringHash = 11; // % 11 -> 0, but ends up at idx 1 because 0 taken
entry3->stringHash = 12; // % 11 -> 1, but ends up at idx 2 because 1 taken
entry4->stringHash = 12; // % 11 -> 1, but ends up at idx 3 because 1+2 taken
// trigger insertion
table.asPropertyKey(entry1);
table.asPropertyKey(entry2);
table.asPropertyKey(entry3);
table.asPropertyKey(entry4);
QCOMPARE(table.size, 4);
QCOMPARE(table.alloc, 11);
QCOMPARE(table.entriesByHash[0], entry1);
QCOMPARE(table.entriesByHash[1], entry2);
QCOMPARE(table.entriesByHash[2], entry3);
QCOMPARE(table.entriesByHash[3], entry4);
QCOMPARE(table.entriesByHash[4], nullptr);
// first entry not marked
entry2->setMarkBit();
entry3->setMarkBit();
entry4->setMarkBit();
table.sweep();
QCOMPARE(table.entriesByHash[0], entry2);
QCOMPARE(table.entriesByHash[1], entry3);
QCOMPARE(table.entriesByHash[2], entry4);
QCOMPARE(table.entriesByHash[3], nullptr);
}
QTEST_MAIN(tst_qv4identifiertable)
#include "tst_qv4identifiertable.moc"
|
