Fix QNetworkSettingsManager usage from the C++

Fixed servicesChanged signal handling.
Fixed services and interfaces functions return types in QNetworkSettingsManager.

Task-number: QTBUG-56760
Change-Id: Iaade0d5c06e8ff8f8dea4b421e226ae6348a9fe5
Reviewed-by: Rainer Keller <Rainer.Keller@qt.io>

1 files changed, 40 insertions, 20 deletions

diff --git a/src/networksettings/connman/qnetworksettingsmanager_p.cpp b/src/networksettings/connman/qnetworksettingsmanager_p.cpp
index 6fecd86..22e8005 100644
--- a/src/networksettings/connman/qnetworksettingsmanager_p.cpp
+++ b/src/networksettings/connman/qnetworksettingsmanager_p.cpp
@@ -98,25 +98,7 @@ void QNetworkSettingsManagerPrivate::getServicesFinished(QDBusPendingCallWatcher
 
     foreach (const ConnmanMapStruct &object, reply.value()) {
         const QString servicePath = object.objectPath.path();
-        QNetworkSettingsService *service = new QNetworkSettingsService(servicePath, this);
-        m_serviceModel->append(service);
-
-        //Update status property
-        QString n = qdbus_cast<QString>(object.propertyMap[PropertyName]);
-        QString t = qdbus_cast<QString>(object.propertyMap[PropertyType]);
-        QString s = qdbus_cast<QString>(object.propertyMap[PropertyState]);
-
-        QNetworkSettingsType type;
-        t >> type;
-        QNetworkSettingsState state;
-        s >> state;
-
-        foreach (QNetworkSettingsInterface* item, m_interfaceModel.getModel()) {
-            ConnmanSettingsInterface* technology = qobject_cast<ConnmanSettingsInterface*>(item);
-            if (technology->name() == n && technology->type() == type.type()) {
-                technology->setState(state.state());
-            }
-        }
+        handleNewService(servicePath);
     }
     emit q->servicesChanged();
 }
@@ -161,9 +143,26 @@ void QNetworkSettingsManagerPrivate::onServicesChanged(ConnmanMapStructList chan
         if (!found)
             newServices.append(map.objectPath.path());
     }
+
     foreach (QString newService, newServices) {
-        QNetworkSettingsService *service = new QNetworkSettingsService(newService, this);
+        handleNewService(newService);
+    }
+}
+
+void QNetworkSettingsManagerPrivate::handleNewService(const QString &servicePath)
+{
+    Q_Q(QNetworkSettingsManager);
+
+    QNetworkSettingsService *service = new QNetworkSettingsService(servicePath, this);
+
+    if (service->name().length() > 0 && service->type() != QNetworkSettingsType::Unknown) {
         m_serviceModel->append(service);
+        emit q->servicesChanged();
+    }
+    else {
+        //Service name or type not set, wait for update
+        connect(service, &QNetworkSettingsService::nameChanged, this, &QNetworkSettingsManagerPrivate::serviceReady);
+        connect(service, &QNetworkSettingsService::typeChanged, this, &QNetworkSettingsManagerPrivate::serviceReady);
     }
 }
 
@@ -171,3 +170,24 @@ void QNetworkSettingsManagerPrivate::setUserAgent(QNetworkSettingsUserAgent *age
 {
     m_agent = agent;
 }
+
+void QNetworkSettingsManagerPrivate::serviceReady()
+{
+    Q_Q(QNetworkSettingsManager);
+
+    QNetworkSettingsService* service = qobject_cast<QNetworkSettingsService*>(sender());
+    if (service->name().length() > 0 && service->type() != QNetworkSettingsType::Unknown) {
+        service->disconnect(this);
+        m_serviceModel->append(service);
+        emit q->servicesChanged();
+
+        //Update the interface state accordingly
+        foreach (QNetworkSettingsInterface* item, m_interfaceModel.getModel()) {
+            ConnmanSettingsInterface* technology = qobject_cast<ConnmanSettingsInterface*>(item);
+            if (technology->name() == service->name() && technology->type() == service->type()) {
+                technology->setState(technology->state());
+            }
+        }
+
+    }
+}