From 27f7f769ba345d7899e4dc10b43a477ababbc99a Mon Sep 17 00:00:00 2001 From: Samuli Piippo Date: Fri, 17 Sep 2021 11:33:13 +0300 Subject: CMake: use LIBRARIES in plugins Fix CMake warnings caused by using PUBLIC_LIBRARIES in plugins. Plugins are not intended to be linked to. They should not have any public properties, but LIBRARIES instead of PUBLIC_LIBRARIES. Pick-to: 6.2 Change-Id: I35644c7ea97f03f26086c2ae5d2ea14a9e7a0a78 Reviewed-by: Mikko Gronoff --- src/networksettings/CMakeLists.txt | 2 +- src/networksettings/networksettingsqml/CMakeLists.txt | 2 +- src/settingsui/qtbuttonimageproviderplugin/CMakeLists.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/networksettings/CMakeLists.txt b/src/networksettings/CMakeLists.txt index 083b43f..daf0b30 100644 --- a/src/networksettings/CMakeLists.txt +++ b/src/networksettings/CMakeLists.txt @@ -27,7 +27,7 @@ qt_internal_add_module(NetworkSettings -iconnmancommon.h # special case INCLUDE_DIRECTORIES connman - PUBLIC_LIBRARIES + LIBRARIES Qt::Core Qt::DBus Qt::Network diff --git a/src/networksettings/networksettingsqml/CMakeLists.txt b/src/networksettings/networksettingsqml/CMakeLists.txt index a2c8403..db3f58c 100644 --- a/src/networksettings/networksettingsqml/CMakeLists.txt +++ b/src/networksettings/networksettingsqml/CMakeLists.txt @@ -7,7 +7,7 @@ qt_internal_add_qml_module(networksettingsqml QtQml SOURCES qnetworksettingsforeign.h qnetworksettingsforeign.cpp - PUBLIC_LIBRARIES + LIBRARIES Qt::Core Qt::Qml Qt::NetworkSettings diff --git a/src/settingsui/qtbuttonimageproviderplugin/CMakeLists.txt b/src/settingsui/qtbuttonimageproviderplugin/CMakeLists.txt index 410caea..d799013 100644 --- a/src/settingsui/qtbuttonimageproviderplugin/CMakeLists.txt +++ b/src/settingsui/qtbuttonimageproviderplugin/CMakeLists.txt @@ -16,7 +16,7 @@ qt_internal_add_qml_module(qtbuttonimageproviderplugin SOURCES plugin.cpp plugin_p.h qtbuttonimageprovider.cpp qtbuttonimageprovider.h - PUBLIC_LIBRARIES + LIBRARIES Qt::Core Qt::Gui Qt::Qml -- cgit v1.2.3