summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMoody Liu <mooodyhunter@outlook.com>2022-06-17 23:21:45 +0100
committerMoody Liu <mooodyhunter@outlook.com>2022-06-20 09:21:32 +0000
commitad2e721683b7c68748b05862fe8cf33bf63ebf55 (patch)
tree90f758faf8f5af1c1ffb11265376f71dbde9a899
parenta15883c544c5522a0a467030e9ee8ab098b4c6ad (diff)
jp2: use correct buffer_size for jas_stream_memopen
According to jasper's documentation, the second argument should be 0 instead of -1, to acquire such a dynamically growing buffer. This also causes a runtime crash due to the signedness of size_t. Fixes: QTBUG-104398 Pick-to: 6.4 6.3 6.2 5.15 Change-Id: I173c6b7c9802c22fe0fa01083a71bf3b6ca7b134 Reviewed-by: Liang Qi <liang.qi@qt.io>
-rw-r--r--src/plugins/imageformats/jp2/qjp2handler.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/imageformats/jp2/qjp2handler.cpp b/src/plugins/imageformats/jp2/qjp2handler.cpp
index 1329af9..4e3308d 100644
--- a/src/plugins/imageformats/jp2/qjp2handler.cpp
+++ b/src/plugins/imageformats/jp2/qjp2handler.cpp
@@ -817,7 +817,7 @@ bool Jpeg2000JasperReader::write(const QImage &image, int quality)
}
// Open an empty jasper stream that grows automatically
- jas_stream_t * memory_stream = jas_stream_memopen(0, -1);
+ jas_stream_t * memory_stream = jas_stream_memopen(0, 0);
// Jasper wants a non-const string.
char *str = qstrdup(jasperFormatString.toLatin1().constData());