From 7e7aa7a6591222a11a7268f6c73b724a7da1b880 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Sat, 15 Oct 2016 00:53:41 +0200 Subject: QWebpHandler/QDDSHandler: init all fields Coverity complained about uninitialised members of m_features in QWebpHandler, and m_header and m_header10 in QDDSHandler, so force value-initialization, in this case zero-initialization, by explicitly adding the fields to the ctor-init-list. Coverity-Id: 21998 Coverity-Id: 22032 Change-Id: Ie45023eda82b7034a0b3e33bab4fb23465cdc7cf Reviewed-by: Giuseppe D'Angelo --- src/plugins/imageformats/dds/qddshandler.cpp | 2 ++ src/plugins/imageformats/webp/qwebphandler.cpp | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/plugins/imageformats/dds/qddshandler.cpp b/src/plugins/imageformats/dds/qddshandler.cpp index 81e967b..f146b95 100644 --- a/src/plugins/imageformats/dds/qddshandler.cpp +++ b/src/plugins/imageformats/dds/qddshandler.cpp @@ -1368,7 +1368,9 @@ static int formatByName(const QByteArray &name) } QDDSHandler::QDDSHandler() : + m_header(), m_format(FormatA8R8G8B8), + m_header10(), m_currentImage(0), m_scanState(ScanNotScanned) { diff --git a/src/plugins/imageformats/webp/qwebphandler.cpp b/src/plugins/imageformats/webp/qwebphandler.cpp index 41a568d..2925574 100644 --- a/src/plugins/imageformats/webp/qwebphandler.cpp +++ b/src/plugins/imageformats/webp/qwebphandler.cpp @@ -42,7 +42,8 @@ static const int riffHeaderSize = 12; // RIFF_HEADER_SIZE from webp/format_const QWebpHandler::QWebpHandler() : m_lossless(false), m_quality(75), - m_scanState(ScanNotScanned) + m_scanState(ScanNotScanned), + m_features() { } -- cgit v1.2.3