From 5dd498f9ba91da91edba1f4bd4a9cd5005490206 Mon Sep 17 00:00:00 2001 From: Mike Morris Date: Wed, 3 Feb 2016 15:44:47 -0500 Subject: [node] patch a memory leak in NodeMap::request Creating a v8::Function with Nan::GetFunction(Nan::New) can leak, use Nan::New instead. https://code.google.com/p/chromium/issues/detail?id=272579 --- package.json | 2 +- platform/node/src/node_map.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index aa88c983d..d99ed46f0 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "mapbox-gl-native", - "version": "3.0.1", + "version": "3.0.2-pre.1", "description": "Renders map tiles with Mapbox GL", "keywords": [ "mapbox", diff --git a/platform/node/src/node_map.cpp b/platform/node/src/node_map.cpp index f5ebae110..b8927ea33 100644 --- a/platform/node/src/node_map.cpp +++ b/platform/node/src/node_map.cpp @@ -462,7 +462,7 @@ std::unique_ptr NodeMap::request(const mbgl::Resource& resour Nan::HandleScope scope; auto requestHandle = NodeRequest::Create(res, cb2)->ToObject(); - auto callbackHandle = Nan::GetFunction(Nan::New(NodeRequest::Respond, requestHandle)).ToLocalChecked(); + auto callbackHandle = Nan::New(NodeRequest::Respond, requestHandle); v8::Local argv[] = { requestHandle, callbackHandle }; Nan::MakeCallback(handle()->GetInternalField(1)->ToObject(), "request", 2, argv); -- cgit v1.2.3