diff options
| author | Tim Blechmann <tim@klingt.org> | 2024-04-16 10:48:27 +0800 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2024-04-18 13:48:49 +0000 |
| commit | ba132072ca155b46c5ca40f6c38c5d26f2ed1708 (patch) | |
| tree | 3df8110edc85dbf0cb134e31c281dc9ca0461b02 | |
| parent | fa8a6c2db780999436cdb6721ce2d40d3ba84e92 (diff) | |
GStreamer: tweak thumbnail test
Qt interprets GST_TAG_IMAGE as CoverArtImage and GST_TAG_PREVIEW_IMAGE
as ThumbnailImage. This is the reverse of the ffmpeg backend.
Task-number: QTBUG-124380
Pick-to: 6.5
Change-Id: Ifb8f2837775893a55de7516fff82772292deab12
Reviewed-by: Artem Dyomin <artem.dyomin@qt.io>
(cherry picked from commit 6d62ffd1100cf42716de6bb76223ec899fec650d)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| -rw-r--r-- | tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp b/tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp index d195eabfe..52e89a2be 100644 --- a/tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp +++ b/tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp @@ -2162,6 +2162,10 @@ void tst_QMediaPlayerBackend::metadata_returnsMetadataWithThumbnail_whenMediaHas void tst_QMediaPlayerBackend::metadata_returnsMetadataWithThumbnail_whenMediaHasThumbnail() { + // QTBUG-124380: gstreamer reports CoverArtImage instead of ThumbnailImage + QMediaMetaData::Key key = + isGStreamerPlatform() ? QMediaMetaData::CoverArtImage : QMediaMetaData::ThumbnailImage; + // Arrange QFETCH(const MaybeUrl, mediaUrl); QFETCH(const bool, hasThumbnail); @@ -2175,7 +2179,7 @@ void tst_QMediaPlayerBackend::metadata_returnsMetadataWithThumbnail_whenMediaHas // Act const QMediaMetaData metadata = m_fixture->player.metaData(); - const QImage thumbnail = metadata.value(QMediaMetaData::ThumbnailImage).value<QImage>(); + const QImage thumbnail = metadata.value(key).value<QImage>(); // Assert QCOMPARE_EQ(!thumbnail.isNull(), hasThumbnail); |