diff options
| author | Artem Dyomin <artem.dyomin@qt.io> | 2023-08-02 09:14:06 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2023-08-02 10:33:27 +0000 |
| commit | 106ef9957c284870fd8d991b639f97fac2c1739c (patch) | |
| tree | bb86251059de349c406983ef3ae13e6d56742846 | |
| parent | ba28889b2cec6ebb99b5f952fdb5dab090321148 (diff) | |
Remove processEvents from the destructor of QPulseAudioSink
Processing events in such places causes unexpected behavior,
including postponed objects deleting.
As result, we got spurious crashes on CI.
The crutch with events processing was added many years ago by
unknown reason; the destructor is definitely a bad place for it.
Change-Id: I0f31598947e6eb098b58244c617ff5eb05186176
Reviewed-by: Pavel Dubsky <pavel.dubsky@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Artem Dyomin <artem.dyomin@qt.io>
(cherry picked from commit 0ecfced06cc46a0dd16c9aae281a8ee3ad3ac87e)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| -rw-r--r-- | src/multimedia/pulseaudio/qpulseaudiosink.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/multimedia/pulseaudio/qpulseaudiosink.cpp b/src/multimedia/pulseaudio/qpulseaudiosink.cpp index bed3714a0..5ac27d9df 100644 --- a/src/multimedia/pulseaudio/qpulseaudiosink.cpp +++ b/src/multimedia/pulseaudio/qpulseaudiosink.cpp @@ -123,7 +123,6 @@ QPulseAudioSink::~QPulseAudioSink() QSignalBlocker blocker(this); guard.reset(); } - QCoreApplication::processEvents(); } QAudio::Error QPulseAudioSink::error() const |