summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJøger Hansegård <joger.hansegard@qt.io>2023-08-09 12:07:16 +0200
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2023-08-09 23:05:46 +0000
commit1bffce8df1a8534d742797fa0b4702057de5ab92 (patch)
treeef6f0cd56c9cc8a310bcad4b993b482b60575982
parentf41df38df5d14f8afbdd4f6226ab7268cb4d009a (diff)
[Multimedia] Fix window capture memory leak on Windows
The Windows UWP window capture backend failed to release its frame buffer when stopping capture. This patch fixes this issue. Change-Id: I0accfd1a6f350438bf51f0bd18f5ea64e5ba1557 Reviewed-by: Artem Dyomin <artem.dyomin@qt.io> Reviewed-by: Pavel Dubsky <pavel.dubsky@qt.io> (cherry picked from commit 302cf88fcb780ac0c366eea570cff84ee197a33c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
-rw-r--r--src/plugins/multimedia/ffmpeg/qffmpegwindowcapture_uwp.cpp6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/plugins/multimedia/ffmpeg/qffmpegwindowcapture_uwp.cpp b/src/plugins/multimedia/ffmpeg/qffmpegwindowcapture_uwp.cpp
index e6cd05004..959a3a962 100644
--- a/src/plugins/multimedia/ffmpeg/qffmpegwindowcapture_uwp.cpp
+++ b/src/plugins/multimedia/ffmpeg/qffmpegwindowcapture_uwp.cpp
@@ -165,7 +165,11 @@ struct WindowGrabber
m_session.StartCapture();
}
- ~WindowGrabber() { m_session.Close(); }
+ ~WindowGrabber()
+ {
+ m_framePool.Close();
+ m_session.Close();
+ }
com_ptr<IDXGISurface> tryGetFrame()
{