summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Knoll <lars.knoll@qt.io>2021-05-26 10:31:07 +0200
committerLars Knoll <lars.knoll@qt.io>2021-05-26 10:19:10 +0000
commit6fef3545e8ae173ac32bd91cbdc5072783dcf604 (patch)
treef98da9452fa4e06126c974802e89bb4fe2da3083
parent5eec4e2fbfc9134453dae245aff98a6e942172a0 (diff)
Fix crash in qsoundeffect autotest on Windows
These lines were added to fix an issue on gstreamer, that does not exist anymore. Remove them, as they cause recursion back into QWindowsAudioOutput that lead to accessing freed memory. Change-Id: Ibd3607d12ae8118f50538364a8b3f01112da8b73 Reviewed-by: André de la Rocha <andre.rocha@qt.io> Reviewed-by: Lars Knoll <lars.knoll@qt.io>
-rw-r--r--src/multimedia/audio/qsoundeffect.cpp2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/multimedia/audio/qsoundeffect.cpp b/src/multimedia/audio/qsoundeffect.cpp
index 51809bf26..2ab2bd262 100644
--- a/src/multimedia/audio/qsoundeffect.cpp
+++ b/src/multimedia/audio/qsoundeffect.cpp
@@ -181,8 +181,6 @@ qint64 QSoundEffectPrivate::readData(char *data, qint64 len)
m_offset = 0;
}
}
- if (!m_runningCount)
- setPlaying(false);
return bytesWritten;
}