diff options
| author | Jędrzej Nowacki <jedrzej.nowacki@digia.com> | 2014-01-15 16:56:12 +0100 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2014-01-15 17:12:41 +0100 |
| commit | e485e066acde8799c3b592aa1dcb62a6dfcb6604 (patch) | |
| tree | 27349edea472933696e26f983f2d091aabe461f7 /src/multimedia/playback/playlistfileparser.cpp | |
| parent | 15025088eac53d97705191d06b13868d62977155 (diff) | |
Use QStringRef instead of QString whenever possible.
That way we reduce count of temporary QString instances.
Change-Id: Id806c68ea616828c2355c07b8576616fa6a8da17
Reviewed-by: Yoann Lopes <yoann.lopes@digia.com>
Diffstat (limited to 'src/multimedia/playback/playlistfileparser.cpp')
| -rw-r--r-- | src/multimedia/playback/playlistfileparser.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/multimedia/playback/playlistfileparser.cpp b/src/multimedia/playback/playlistfileparser.cpp index 03d84444e..1dc93aa7a 100644 --- a/src/multimedia/playback/playlistfileparser.cpp +++ b/src/multimedia/playback/playlistfileparser.cpp @@ -100,7 +100,7 @@ public: m_extraInfo.clear(); int artistStart = line.indexOf(QLatin1String(","), 8); bool ok = false; - int length = line.mid(8, artistStart < 8 ? -1 : artistStart - 8).trimmed().toInt(&ok); + int length = line.midRef(8, artistStart < 8 ? -1 : artistStart - 8).trimmed().toInt(&ok); if (ok && length > 0) { //convert from second to milisecond m_extraInfo[QMediaMetaData::Duration] = QVariant(length * 1000); @@ -108,13 +108,13 @@ public: if (artistStart > 0) { int titleStart = getSplitIndex(line, artistStart); if (titleStart > artistStart) { - m_extraInfo[QMediaMetaData::Author] = line.mid(artistStart + 1, - titleStart - artistStart - 1).trimmed(). + m_extraInfo[QMediaMetaData::Author] = line.midRef(artistStart + 1, + titleStart - artistStart - 1).trimmed().toString(). replace(QLatin1String("--"), QLatin1String("-")); - m_extraInfo[QMediaMetaData::Title] = line.mid(titleStart + 1).trimmed(). + m_extraInfo[QMediaMetaData::Title] = line.midRef(titleStart + 1).trimmed().toString(). replace(QLatin1String("--"), QLatin1String("-")); } else { - m_extraInfo[QMediaMetaData::Title] = line.mid(artistStart + 1).trimmed(). + m_extraInfo[QMediaMetaData::Title] = line.midRef(artistStart + 1).trimmed().toString(). replace(QLatin1String("--"), QLatin1String("-")); } } @@ -302,7 +302,7 @@ Version=2 emit error(QPlaylistFileParser::FormatError, QString(tr("Error parsing playlist at line[%1]:%2")).arg(QString::number(lineIndex), line)); return QString(); } - return line.mid(start + 1).trimmed(); + return line.midRef(start + 1).trimmed().toString(); } void setCount(int count) { |