fix expensive iteration over QMap::keys() and QHash::keys()

Change-Id: I244aa1ecf006774ebe5fb9bb5b22d37142186e39
Reviewed-by: Yoann Lopes <yoann.lopes@theqtcompany.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/multimedia/playback/qmediaresource.cpp b/src/multimedia/playback/qmediaresource.cpp
index 955837d2c..0813ab82e 100644
--- a/src/multimedia/playback/qmediaresource.cpp
+++ b/src/multimedia/playback/qmediaresource.cpp
@@ -145,14 +145,14 @@ QMediaResource::~QMediaResource()
 bool QMediaResource::operator ==(const QMediaResource &other) const
 {
     // Compare requests directly as QNetworkRequests are "custom types".
-    foreach (int key, values.keys()) {
-        switch (key) {
+    for (auto it = values.cbegin(), end = values.cend(); it != end; ++it) {
+        switch (it.key()) {
         case Request:
             if (request() != other.request())
                 return false;
         break;
         default:
-            if (values.value(key) != other.values.value(key))
+            if (it.value() != other.values.value(it.key()))
                 return false;
         }
     }