diff options
| author | Dmytro Poplavskiy <dmytro.poplavskiy@nokia.com> | 2012-05-14 13:10:09 +1000 |
|---|---|---|
| committer | Qt by Nokia <qt-info@nokia.com> | 2012-05-14 08:37:45 +0200 |
| commit | fdb5c419c4fb7b1ae0268e496ccdd0ffa03b74ce (patch) | |
| tree | 1e8c85fd7d6abf30e831a3f65649d932a40f071d /src/multimedia | |
| parent | 08d45baac2b56b625194e7b62ce8bff0529218fc (diff) | |
Gst backend: allow rendering other video buffers than allocated
Moved checking the buffer type to the buffer pool
instead of comparing the buffer type in QVideoSurfaceGstSink.
Some gstreamer elements may push other buffer instance than
provided by sink but with the same data pointer.
Change-Id: Iab3bf4da2d5eeb5d2a9375aa609a89515b067ce3
Reviewed-by: Lev Zelenskiy <lev.zelenskiy@nokia.com>
Reviewed-by: Ling Hu <ling.hu@nokia.com>
Diffstat (limited to 'src/multimedia')
| -rw-r--r-- | src/multimedia/gsttools_headers/qgstbufferpoolinterface_p.h | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/src/multimedia/gsttools_headers/qgstbufferpoolinterface_p.h b/src/multimedia/gsttools_headers/qgstbufferpoolinterface_p.h index 42c4fb55c..929e7c68f 100644 --- a/src/multimedia/gsttools_headers/qgstbufferpoolinterface_p.h +++ b/src/multimedia/gsttools_headers/qgstbufferpoolinterface_p.h @@ -73,16 +73,14 @@ public: virtual ~QGstBufferPoolInterface() {} virtual bool isFormatSupported(const QVideoSurfaceFormat &format) const = 0; - - virtual GType bufferType() const = 0; virtual GstBuffer *takeBuffer(const QVideoSurfaceFormat &format, GstCaps *caps) = 0; virtual void clear() = 0; virtual QAbstractVideoBuffer::HandleType handleType() const = 0; /*! - Build an QAbstractVideoBuffer instance from compatible (mathcing gst buffer type) - GstBuffer. + Build an QAbstractVideoBuffer instance from GstBuffer. + Returns NULL if GstBuffer is not compatible with this buffer pool. This method is called from gstreamer video sink thread. */ @@ -101,16 +99,14 @@ public: virtual ~QGstBufferPoolPlugin() {} virtual bool isFormatSupported(const QVideoSurfaceFormat &format) const = 0; - - virtual GType bufferType() const = 0; virtual GstBuffer *takeBuffer(const QVideoSurfaceFormat &format, GstCaps *caps) = 0; virtual void clear() = 0; virtual QAbstractVideoBuffer::HandleType handleType() const = 0; /*! - Build an QAbstractVideoBuffer instance from compatible (mathcing gst buffer type) - GstBuffer. + Build an QAbstractVideoBuffer instance from compatible GstBuffer. + Returns NULL if GstBuffer is not compatible with this buffer pool. This method is called from gstreamer video sink thread. */ |