diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2019-06-12 12:51:54 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2019-06-12 15:20:38 +0200 |
| commit | 282356e3a1b1d95fd5d9433fb633a9692b84c8d7 (patch) | |
| tree | f814d9b8fb73b7a382212c249497c3ba97f08bd5 /src/plugins/directshow/camera/dscamerasession.cpp | |
| parent | 451bdd16caba3483139ed49f035caa1731510bf7 (diff) | |
DirectShow: Clang warnings about else after return, break
Disentangle code of DirectShowPlayerService::requestControl().
Change-Id: I2e90d5c86acdbe2f20f421f43929e0e9c5580eaf
Reviewed-by: André de la Rocha <andre.rocha@qt.io>
Diffstat (limited to 'src/plugins/directshow/camera/dscamerasession.cpp')
| -rw-r--r-- | src/plugins/directshow/camera/dscamerasession.cpp | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/src/plugins/directshow/camera/dscamerasession.cpp b/src/plugins/directshow/camera/dscamerasession.cpp index f69c0d624..4c9100282 100644 --- a/src/plugins/directshow/camera/dscamerasession.cpp +++ b/src/plugins/directshow/camera/dscamerasession.cpp @@ -784,13 +784,9 @@ bool DSCameraSession::createFilterGraph() reinterpret_cast<void**>(&m_sourceFilter)); pPropBag->Release(); pMoniker->Release(); - if (SUCCEEDED(hr)) { + if (SUCCEEDED(hr)) break; // done, stop looping through - } - else - { - qWarning() << "Object bind failed"; - } + qWarning("Object bind failed"); } } } |