diff options
author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-09-05 09:12:49 +0200 |
---|---|---|
committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-09-05 12:15:09 +0000 |
commit | a9789cf46b19726e201069e9d4dfee48f0570691 (patch) | |
tree | cb3d4d73ce52597e1661b8013f71367f781355ae /src/plugins/directshow/common/directshowvideobuffer.h | |
parent | 35ace9e289dcaada5e0828a59ca7dfee78a6342c (diff) |
DirectShow: Fix clang-tidy warnings about class definitions
- Use ' = default' for trivial constructors/destructors
- replace virtual by override or add override where applicable
- Replace trivial constructors by member initialization for simple structs
- Add Q_DISABLE_COPY where applicable
- Mark move assignment/move constructors as noexcept
- Remove unused member variables
Change-Id: I579fb69ebcd945b94de32b827d93e5a4dab4df97
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
Diffstat (limited to 'src/plugins/directshow/common/directshowvideobuffer.h')
-rw-r--r-- | src/plugins/directshow/common/directshowvideobuffer.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/plugins/directshow/common/directshowvideobuffer.h b/src/plugins/directshow/common/directshowvideobuffer.h index 85e02b53d..a85a3ca34 100644 --- a/src/plugins/directshow/common/directshowvideobuffer.h +++ b/src/plugins/directshow/common/directshowvideobuffer.h @@ -50,14 +50,14 @@ class DirectShowVideoBuffer : public QAbstractVideoBuffer { public: DirectShowVideoBuffer(IMediaSample *sample, int bytesPerLine); - ~DirectShowVideoBuffer(); + ~DirectShowVideoBuffer() override; IMediaSample *sample() { return m_sample; } - uchar *map(MapMode mode, int *numBytes, int *bytesPerLine); - void unmap(); + uchar *map(MapMode mode, int *numBytes, int *bytesPerLine) override; + void unmap() override; - MapMode mapMode() const; + MapMode mapMode() const override; private: IMediaSample *m_sample; |