diff options
author | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-01-14 15:09:36 +0300 |
---|---|---|
committer | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-01-14 12:49:59 +0000 |
commit | 9c43f48d118ff869a9a621e1cea1ed2df81d2f37 (patch) | |
tree | 2758ed5b1b1451626668d6bc9e39162b2c5730c5 /src/plugins/gstreamer/camerabin/camerabinmetadata.cpp | |
parent | a12f3d6fee700fb19b51b85934acddf536c483cf (diff) |
fix expensive iteration over QMap::keys() and QHash::keys()
Change-Id: I244aa1ecf006774ebe5fb9bb5b22d37142186e39
Reviewed-by: Yoann Lopes <yoann.lopes@theqtcompany.com>
Diffstat (limited to 'src/plugins/gstreamer/camerabin/camerabinmetadata.cpp')
-rw-r--r-- | src/plugins/gstreamer/camerabin/camerabinmetadata.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/gstreamer/camerabin/camerabinmetadata.cpp b/src/plugins/gstreamer/camerabin/camerabinmetadata.cpp index e404065fc..ec2a83a66 100644 --- a/src/plugins/gstreamer/camerabin/camerabinmetadata.cpp +++ b/src/plugins/gstreamer/camerabin/camerabinmetadata.cpp @@ -244,8 +244,8 @@ QStringList CameraBinMetaData::availableMetaData() const } QStringList res; - Q_FOREACH (const QByteArray &key, m_values.keys()) { - QString tag = keysMap.value(key); + for (auto it = m_values.keyBegin(), end = m_values.keyEnd(); it != end; ++it) { + QString tag = keysMap.value(*it); if (!tag.isEmpty()) res.append(tag); } |