diff options
author | bigbearzhu <jun.5.zhu@nokia.com> | 2012-03-30 16:07:49 +1000 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-04-04 02:46:58 +0200 |
commit | df3f5d790f361932f2ca3e6371b486496735a367 (patch) | |
tree | 1371e28a5db78c4941d2bf3be7eb3f83e6432ad6 /src/plugins/gstreamer/mediaplayer/qgstreamerplayersession.cpp | |
parent | 37627f76809d6146b55b78bb7af2cf2fd0bbf7b7 (diff) |
Fixed major mem leak of unfreed GstTagList when playing ogg files.
Could cause serious leak if ogg files contain coverart image.
Should use gst_tag_list_fee to free the used taglist.
Change-Id: I8f7b799729b84ad9a2ca45bc3e31f37a987a5885
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Diffstat (limited to 'src/plugins/gstreamer/mediaplayer/qgstreamerplayersession.cpp')
-rw-r--r-- | src/plugins/gstreamer/mediaplayer/qgstreamerplayersession.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/plugins/gstreamer/mediaplayer/qgstreamerplayersession.cpp b/src/plugins/gstreamer/mediaplayer/qgstreamerplayersession.cpp index cb8f6f227..3fa93f02d 100644 --- a/src/plugins/gstreamer/mediaplayer/qgstreamerplayersession.cpp +++ b/src/plugins/gstreamer/mediaplayer/qgstreamerplayersession.cpp @@ -961,6 +961,7 @@ bool QGstreamerPlayerSession::processBusMessage(const QGstreamerMessage &message gst_message_parse_tag(gm, &tag_list); m_tags.unite(QGstUtils::gstTagListToMap(tag_list)); + gst_tag_list_free(tag_list); //qDebug() << m_tags; emit tagsChanged(); @@ -1316,6 +1317,7 @@ void QGstreamerPlayerSession::getStreamsInfo() //qDebug() << "language for setream" << i << QString::fromUtf8(languageCode); g_free (languageCode); + gst_tag_list_free(tags); } m_streamProperties.append(streamProperties); |