diff options
| author | Oliver Wolff <oliver.wolff@qt.io> | 2018-04-16 14:47:42 +0200 |
|---|---|---|
| committer | Oliver Wolff <oliver.wolff@qt.io> | 2018-04-17 05:50:40 +0000 |
| commit | 4ae65d3c93bd1f87ac8003a7f244285a1ba624b6 (patch) | |
| tree | e586ec09bb7648f8dcc21cb4cf96c7eff9d75f77 /src | |
| parent | 32b8e622c0b551d8f67a64a9dee834c5732bfea8 (diff) | |
DirectShowUtils::findUnconnectedPin: Try other pins if matchPin fails
If matchPin fails for one of the pins (for whatever reason), the loop
can just continue and check whether another unconnected pin can be found.
If this check fails for every pin, false will be returned in the end.
Change-Id: I1a58a26633b43052f3963212932d789d4800c714
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: VaL Doroshchuk <valentyn.doroshchuk@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/plugins/directshow/common/directshowutils.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/plugins/directshow/common/directshowutils.cpp b/src/plugins/directshow/common/directshowutils.cpp index 989239b88..8f3f321e7 100644 --- a/src/plugins/directshow/common/directshowutils.cpp +++ b/src/plugins/directshow/common/directshowutils.cpp @@ -183,9 +183,6 @@ bool DirectShowUtils::findUnconnectedPin(IBaseFilter *filter, PIN_DIRECTION pinD (*pin)->AddRef(); return true; } - - if (FAILED(*hrOut)) - return false; } qCDebug(qtDirectShowPlugin, "No unconnected pins found"); |