diff options
| author | Oliver Wolff <oliver.wolff@qt.io> | 2018-04-16 14:39:52 +0200 |
|---|---|---|
| committer | Oliver Wolff <oliver.wolff@qt.io> | 2018-04-17 05:50:34 +0000 |
| commit | 9248dc9d16d5d4dc8fdfaf17344ca59f4a4eb7c4 (patch) | |
| tree | 992f7da3ceaca8341336328302f0f2d9d52fc9e2 /src | |
| parent | bb6f66a420ba4717312877ccd6fa0369a02dd239 (diff) | |
DirectShowUtils::matchPin: Return false on connection mismatch
If the pin's connection state does not match shouldBeConnected, the
function has to return false instead of checking the result of the
isPinConnected call.
Change-Id: Id15f054d5847434a5bb06b91bbc1455c6fdd2ded
Reviewed-by: VaL Doroshchuk <valentyn.doroshchuk@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/plugins/directshow/common/directshowutils.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/directshow/common/directshowutils.cpp b/src/plugins/directshow/common/directshowutils.cpp index 96fabd6da..93782e546 100644 --- a/src/plugins/directshow/common/directshowutils.cpp +++ b/src/plugins/directshow/common/directshowutils.cpp @@ -150,7 +150,7 @@ bool DirectShowUtils::matchPin(IPin *pin, PIN_DIRECTION pinDirection, BOOL shoul if (isConnected == shouldBeConnected) return hasPinDirection(pin, pinDirection, hrOut); - return SUCCEEDED(*hrOut); + return false; } /** |