summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorAndrew den Exter <andrew.den.exter@jollamobile.com>2013-04-17 15:13:56 +1000
committerThe Qt Project <gerrit-noreply@qt-project.org>2013-04-17 10:09:07 +0200
commit63f0fcb5d6b33b85812cf867057862064731b4b8 (patch)
treedd03b001569ea256dfa9de0daf572c15c4b793e9 /src
parente728a61eb68c44ef1746804cb379e46be64580e5 (diff)
Fix crash on idle status change with 64 bit architectures.
bool and gboolean are not necessarily the same size on all architectures, and if gboolean is larger than bool then passing it as an argument to g_object_get can trash the stack. In this case overwriting some of the session pointer. Change-Id: Iaa7be6a327e9f69212bd7d5bb372d33f2026db0f Reviewed-by: Andy Nichols <andy.nichols@digia.com>
Diffstat (limited to 'src')
-rw-r--r--src/plugins/gstreamer/camerabin/camerabinsession.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/gstreamer/camerabin/camerabinsession.cpp b/src/plugins/gstreamer/camerabin/camerabinsession.cpp
index f58bea205..2e5c53a4d 100644
--- a/src/plugins/gstreamer/camerabin/camerabinsession.cpp
+++ b/src/plugins/gstreamer/camerabin/camerabinsession.cpp
@@ -672,7 +672,7 @@ void CameraBinSession::updateBusyStatus(GObject *o, GParamSpec *p, gpointer d)
Q_UNUSED(p);
CameraBinSession *session = reinterpret_cast<CameraBinSession *>(d);
- bool idle = false;
+ gboolean idle = false;
g_object_get(o, "idle", &idle, NULL);
bool busy = !idle;