summaryrefslogtreecommitdiffstats
path: root/tests/auto/unit/qmultimedia_common
diff options
context:
space:
mode:
authorDmytro Poplavskiy <dmytro.poplavskiy@nokia.com>2012-01-25 16:24:55 +1000
committerQt by Nokia <qt-info@nokia.com>2012-02-02 02:37:33 +0100
commit6a88794db4b35128eeef1f3514203d375dbba280 (patch)
treede6c3e4cfa072216a02bff9be1f84239652399d4 /tests/auto/unit/qmultimedia_common
parent80eaaa21524d2f8ff8f3eb7b657936a27388d69f (diff)
QCameraImageProcessingControl API fixes
Moved white balance preset from the separate methods to QCameraImageProcessingControl::ProcessingParameter; Separated absolute contrast/saturation/sharpening/denoising settings with adjustments to backend decided values, with QCameraImageProcessing using adjustments versions. Changed type of parameters from int to qreal with [0..1] range for absolute values and [-1..1] for adjustments. Change-Id: I85c8781c046be6dd45bcf626c25908e1ce5f6bcb Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com> Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Diffstat (limited to 'tests/auto/unit/qmultimedia_common')
-rw-r--r--tests/auto/unit/qmultimedia_common/mockcameraimageprocessingcontrol.h57
1 files changed, 32 insertions, 25 deletions
diff --git a/tests/auto/unit/qmultimedia_common/mockcameraimageprocessingcontrol.h b/tests/auto/unit/qmultimedia_common/mockcameraimageprocessingcontrol.h
index 29a3a1b59..eca2d346d 100644
--- a/tests/auto/unit/qmultimedia_common/mockcameraimageprocessingcontrol.h
+++ b/tests/auto/unit/qmultimedia_common/mockcameraimageprocessingcontrol.h
@@ -73,67 +73,75 @@ public:
m_supportedWhiteBalance = modes;
}
- bool isProcessingParameterSupported(ProcessingParameter parameter) const
+ bool isParameterSupported(ProcessingParameter parameter) const
{
- //return parameter == Contrast || parameter == Sharpening || parameter == ColorTemperature;
switch (parameter)
{
- case Contrast:
- case Brightness:
- case Sharpening:
- case Saturation:
- case Denoising:
+ case ContrastAdjustment:
+ case BrightnessAdjustment:
+ case SharpeningAdjustment:
+ case SaturationAdjustment:
+ case DenoisingAdjustment:
case ColorTemperature:
- case ExtendedParameter:
+ case WhiteBalancePreset:
return true;
default :
return false;
}
}
- QVariant processingParameter(ProcessingParameter parameter) const
+
+ bool isParameterValueSupported(ProcessingParameter parameter, const QVariant &value) const
+ {
+ if (parameter != WhiteBalancePreset)
+ return false;
+
+ return m_supportedWhiteBalance.contains(value.value<QCameraImageProcessing::WhiteBalanceMode>());
+ }
+
+ QVariant parameter(ProcessingParameter parameter) const
{
switch (parameter) {
- case Contrast:
+ case ContrastAdjustment:
return m_contrast;
- case Saturation:
+ case SaturationAdjustment:
return m_saturation;
- case Brightness:
+ case BrightnessAdjustment:
return m_brightness;
- case Sharpening:
+ case SharpeningAdjustment:
return m_sharpeningLevel;
- case Denoising:
+ case DenoisingAdjustment:
return m_denoising;
case ColorTemperature:
return m_manualWhiteBalance;
- case ExtendedParameter:
- return m_extendedParameter;
+ case WhiteBalancePreset:
+ return QVariant::fromValue<QCameraImageProcessing::WhiteBalanceMode>(m_whiteBalanceMode);
default:
return QVariant();
}
}
- void setProcessingParameter(ProcessingParameter parameter, QVariant value)
+ void setParameter(ProcessingParameter parameter, const QVariant &value)
{
switch (parameter) {
- case Contrast:
+ case ContrastAdjustment:
m_contrast = value;
break;
- case Saturation:
+ case SaturationAdjustment:
m_saturation = value;
break;
- case Brightness:
+ case BrightnessAdjustment:
m_brightness = value;
break;
- case Sharpening:
+ case SharpeningAdjustment:
m_sharpeningLevel = value;
break;
- case Denoising:
+ case DenoisingAdjustment:
m_denoising = value;
break;
case ColorTemperature:
m_manualWhiteBalance = value;
break;
- case ExtendedParameter:
- m_extendedParameter = value;
+ case WhiteBalancePreset:
+ m_whiteBalanceMode = value.value<QCameraImageProcessing::WhiteBalanceMode>();
break;
default:
break;
@@ -150,7 +158,6 @@ private:
QVariant m_saturation;
QVariant m_brightness;
QVariant m_denoising;
- QVariant m_extendedParameter;
};
#endif // MOCKCAMERAIMAGEPROCESSINGCONTROL_H