diff options
| author | Rafael Roquetto <rafael.roquetto@qt.io> | 2022-05-05 17:10:51 +1000 |
|---|---|---|
| committer | Rafael Roquetto <rafael.roquetto@qt.io> | 2022-05-06 08:43:41 +1000 |
| commit | ea420ab7fd778e18a79fe4ecdccddaa454a21906 (patch) | |
| tree | 01946107a2026b874be4dbe7753aaa41932504f2 /tests | |
| parent | 81f7f3c2a3913c9e333735360ed212aa53f91863 (diff) | |
tst_qmediaplayerbackend: don't check signal count
Do not set the signal count on the signal spies for the position and
state fields. When the media is done playing before the spies are
cleared, it is reasonable that the backends could be already on the
stopped state and on a fixed position (e.g. 0). Resetting the media
source shouldn't necessarily trigger a state change for these fields -
it in fact makes sense that the state remains untouched (e.g. 'Stopped',
or position == '0').
Checking the final state only (which already happens)is a better check
than relying on signal spy counts for this reason.
Change-Id: I49f720e640fa3733154e6ad19272f049b99994a1
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp b/tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp index bb5519321..85d132368 100644 --- a/tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp +++ b/tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp @@ -293,10 +293,8 @@ void tst_QMediaPlayerBackend::unloadMedia() QCOMPARE(player.mediaStatus(), QMediaPlayer::NoMedia); QCOMPARE(player.source(), QUrl()); - QVERIFY(!stateSpy.isEmpty()); QVERIFY(!statusSpy.isEmpty()); QVERIFY(!mediaSpy.isEmpty()); - QVERIFY(!positionSpy.isEmpty()); } void tst_QMediaPlayerBackend::loadMediaInLoadingState() |