From 10c080521c525e1729b23dfa0afd08a1428f40d0 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Thu, 11 Jul 2019 09:59:23 +0200 Subject: Eradicate the last Q_FOREACH and mark the module clean This one is not trivial in that it isn't clear, a priori, that the loop body doesn't re-enter the class and ends up modifying m_videoProbes. But MFVideoProbeControl::bufferProbed() just schedules a deferred call to QMediaVideoProbeControl::videoFrameProbed() (via QueuedConnection), so this cannot happen, because we end the loop before we re-enter the event loop (if any) on this thread. Reentrancy from a different thread, OTOH, is not possible because we're holding m_videoProbeMutex while looping. Change-Id: I6c1e22cd01112f0b2650e056f0b7f4a392370b84 Reviewed-by: VaL Doroshchuk --- .qmake.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.qmake.conf') diff --git a/.qmake.conf b/.qmake.conf index 2c781f2ea..f6895bb09 100644 --- a/.qmake.conf +++ b/.qmake.conf @@ -1,5 +1,5 @@ load(qt_build_config) -DEFINES += QT_NO_JAVA_STYLE_ITERATORS QT_NO_LINKED_LIST +DEFINES += QT_NO_FOREACH QT_NO_JAVA_STYLE_ITERATORS QT_NO_LINKED_LIST MODULE_VERSION = 5.14.0 -- cgit v1.2.3