From 2cba4e8ff7bc0b66674c5b785911e4466c4b9d9b Mon Sep 17 00:00:00 2001 From: Tim Blechmann Date: Tue, 26 Mar 2024 16:13:49 +0800 Subject: GStreamer: include cleanup Pull gstreamer plugin headers in via full path. Also clean up some include paths and remove unnecessary ones. Pick-to: 6.5 Change-Id: I24f8795c66c8a750ddb2e6a3ec046672f70090d0 Reviewed-by: Artem Dyomin (cherry picked from commit 8775acf7ecdc795517c29b939a3f32a38609073a) Reviewed-by: Qt Cherry-pick Bot (cherry picked from commit dfbbd20114352fd4bbd54dbbe4e64e39e1c2a35b) --- src/plugins/multimedia/gstreamer/CMakeLists.txt | 4 --- .../gstreamer/audio/qgstreameraudiodecoder.cpp | 8 ++--- .../gstreamer/audio/qgstreameraudiodecoder_p.h | 14 ++++----- .../gstreamer/audio/qgstreameraudiodevice.cpp | 2 +- .../gstreamer/audio/qgstreameraudiodevice_p.h | 3 +- .../gstreamer/audio/qgstreameraudiosink.cpp | 16 +++++----- .../gstreamer/audio/qgstreameraudiosink_p.h | 4 +-- .../gstreamer/audio/qgstreameraudiosource_p.h | 5 ++-- src/plugins/multimedia/gstreamer/common/qgst_p.h | 2 +- .../multimedia/gstreamer/common/qgstappsrc.cpp | 2 +- .../multimedia/gstreamer/common/qgstappsrc_p.h | 2 +- .../multimedia/gstreamer/common/qgstpipeline_p.h | 2 +- .../gstreamer/common/qgstreameraudioinput.cpp | 11 ++++--- .../gstreamer/common/qgstreameraudioinput_p.h | 4 +-- .../gstreamer/common/qgstreameraudiooutput.cpp | 8 ++--- .../gstreamer/common/qgstreameraudiooutput_p.h | 4 +-- .../gstreamer/common/qgstreamerbufferprobe.cpp | 2 +- .../gstreamer/common/qgstreamermediaplayer.cpp | 25 ++++++++-------- .../gstreamer/common/qgstreamermediaplayer_p.h | 4 +-- .../gstreamer/common/qgstreamermessage_p.h | 2 +- .../gstreamer/common/qgstreamermetadata.cpp | 2 +- .../gstreamer/common/qgstreamervideooutput.cpp | 11 +++---- .../gstreamer/common/qgstreamervideooutput_p.h | 6 ++-- .../gstreamer/common/qgstreamervideooverlay.cpp | 4 +-- .../gstreamer/common/qgstreamervideooverlay_p.h | 6 ++-- .../gstreamer/common/qgstreamervideosink.cpp | 10 +++---- .../gstreamer/common/qgstreamervideosink_p.h | 4 +-- .../gstreamer/common/qgstsubtitlesink_p.h | 2 +- .../multimedia/gstreamer/common/qgstutils.cpp | 2 +- .../multimedia/gstreamer/common/qgstutils_p.h | 2 +- .../gstreamer/common/qgstvideobuffer.cpp | 2 +- .../gstreamer/common/qgstvideobuffer_p.h | 2 +- .../gstreamer/common/qgstvideorenderersink.cpp | 34 +++++++++++----------- .../gstreamer/common/qgstvideorenderersink_p.h | 4 +-- .../gstreamer/mediacapture/qgstreamercamera.cpp | 11 +++---- .../mediacapture/qgstreamerimagecapture.cpp | 27 ++++++++--------- .../mediacapture/qgstreamerimagecapture_p.h | 6 ++-- .../mediacapture/qgstreamermediacapture.cpp | 17 +++++------ .../mediacapture/qgstreamermediacapture_p.h | 4 +-- .../mediacapture/qgstreamermediaencoder.cpp | 31 ++++++++++---------- .../mediacapture/qgstreamermediaencoder_p.h | 10 +++---- .../multimedia/gstreamer/qgstreamerformatinfo.cpp | 2 +- .../multimedia/gstreamer/qgstreamerformatinfo_p.h | 2 +- .../multimedia/gstreamer/qgstreamerintegration.cpp | 27 ++++++++--------- .../gstreamer/qgstreamervideodevices.cpp | 8 ++--- .../gstreamer/qgstreamervideodevices_p.h | 2 +- 46 files changed, 179 insertions(+), 183 deletions(-) diff --git a/src/plugins/multimedia/gstreamer/CMakeLists.txt b/src/plugins/multimedia/gstreamer/CMakeLists.txt index f7ffb612b..2212fd5ba 100644 --- a/src/plugins/multimedia/gstreamer/CMakeLists.txt +++ b/src/plugins/multimedia/gstreamer/CMakeLists.txt @@ -43,10 +43,6 @@ qt_internal_add_plugin(QGstreamerMediaPlugin common/qgstreamervideosink.cpp DEFINES GLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 - INCLUDE_DIRECTORIES - audio - common - mediacapture LIBRARIES Qt::MultimediaPrivate Qt::CorePrivate diff --git a/src/plugins/multimedia/gstreamer/audio/qgstreameraudiodecoder.cpp b/src/plugins/multimedia/gstreamer/audio/qgstreameraudiodecoder.cpp index f77b7e2ce..9c7f52e28 100644 --- a/src/plugins/multimedia/gstreamer/audio/qgstreameraudiodecoder.cpp +++ b/src/plugins/multimedia/gstreamer/audio/qgstreameraudiodecoder.cpp @@ -2,11 +2,11 @@ // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only //#define DEBUG_DECODER -#include "qgstreameraudiodecoder_p.h" -#include "qgstreamermessage_p.h" -#include "qgst_debug_p.h" +#include