From fc1f2b66466c47232292f5783d1528556bdb2d95 Mon Sep 17 00:00:00 2001 From: Mikko Hallamaa Date: Thu, 2 May 2024 11:55:43 +0200 Subject: Fix little/big endian mixup for source audio in ALSA source MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Big/little endian PCM formats were flipped when setting format in ALSA audio source. Fixes: QTBUG-124431 Pick-to: 6.7 6.5 Change-Id: I6aee262856bd9a3243d930778fcaa8fb7295d964 Reviewed-by: Artem Dyomin Reviewed-by: Jøger Hansegård --- src/multimedia/alsa/qalsaaudiosource.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/multimedia/alsa/qalsaaudiosource.cpp b/src/multimedia/alsa/qalsaaudiosource.cpp index ce099463d..951cfeabb 100644 --- a/src/multimedia/alsa/qalsaaudiosource.cpp +++ b/src/multimedia/alsa/qalsaaudiosource.cpp @@ -143,21 +143,21 @@ int QAlsaAudioSource::setFormat() break; case QAudioFormat::Int16: if constexpr (QSysInfo::ByteOrder == QSysInfo::BigEndian) - pcmformat = SND_PCM_FORMAT_S16_LE; - else pcmformat = SND_PCM_FORMAT_S16_BE; + else + pcmformat = SND_PCM_FORMAT_S16_LE; break; case QAudioFormat::Int32: if constexpr (QSysInfo::ByteOrder == QSysInfo::BigEndian) - pcmformat = SND_PCM_FORMAT_S32_LE; - else pcmformat = SND_PCM_FORMAT_S32_BE; + else + pcmformat = SND_PCM_FORMAT_S32_LE; break; case QAudioFormat::Float: if constexpr (QSysInfo::ByteOrder == QSysInfo::BigEndian) - pcmformat = SND_PCM_FORMAT_FLOAT_LE; - else pcmformat = SND_PCM_FORMAT_FLOAT_BE; + else + pcmformat = SND_PCM_FORMAT_FLOAT_LE; default: break; } -- cgit v1.2.3